From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: davinci: da850 evm: update clock rate for UART 1/2 DT nodes
Date: Thu, 28 Feb 2013 16:09:47 +0530 [thread overview]
Message-ID: <512F33F3.9070203@ti.com> (raw)
In-Reply-To: <1361262734-8540-1-git-send-email-prakash.pm@ti.com>
Prakash,
On 2/19/2013 2:02 PM, Manjunathappa, Prakash wrote:
> DT kernel with latest of denx SPL U-boot boots with garbled UART
> logs. This is because in U-boot UART2 gets sourced by PLL0_SYSCLK2
> configured for 150MHz. But later in kernel UART2 gets mapped to
> PLL1_SYSCLK2 and is configured for 132MHz not for 150MHz.
>
> PLL1 is configured for 264MHz to support mDDR on the EVM. That is
> memory controller driving mDDR can be configured for 150MHz and
> mDDR it self can operate at 132MHz.
>
> So override UART1 and UART2 DT node clock-frequency property with
> rate available on da850 EVM.
>
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
How about dropping the clock-frequency attribute altogether? of_serial.c
seems to be falling back on clk apis if frequency is not passed and that
should make the kernel work with all versions of U-Boot.
Thanks,
Sekhar
> ---
> arch/arm/boot/dts/da850-evm.dts | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index f712fb6..c359872 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -22,9 +22,11 @@
> status = "okay";
> };
> serial1: serial at 1d0c000 {
> + clock-frequency = <132000000>;
> status = "okay";
> };
> serial2: serial at 1d0d000 {
> + clock-frequency = <132000000>;
> status = "okay";
> };
> rtc0: rtc at 1c23000 {
>
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
To: "Manjunathappa, Prakash" <prakash.pm-l0cyMroinI0@public.gmane.org>
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org,
hs-ynQEQJNshbs@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: davinci: da850 evm: update clock rate for UART 1/2 DT nodes
Date: Thu, 28 Feb 2013 16:09:47 +0530 [thread overview]
Message-ID: <512F33F3.9070203@ti.com> (raw)
In-Reply-To: <1361262734-8540-1-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
Prakash,
On 2/19/2013 2:02 PM, Manjunathappa, Prakash wrote:
> DT kernel with latest of denx SPL U-boot boots with garbled UART
> logs. This is because in U-boot UART2 gets sourced by PLL0_SYSCLK2
> configured for 150MHz. But later in kernel UART2 gets mapped to
> PLL1_SYSCLK2 and is configured for 132MHz not for 150MHz.
>
> PLL1 is configured for 264MHz to support mDDR on the EVM. That is
> memory controller driving mDDR can be configured for 150MHz and
> mDDR it self can operate at 132MHz.
>
> So override UART1 and UART2 DT node clock-frequency property with
> rate available on da850 EVM.
>
> Signed-off-by: Manjunathappa, Prakash <prakash.pm-l0cyMroinI0@public.gmane.org>
How about dropping the clock-frequency attribute altogether? of_serial.c
seems to be falling back on clk apis if frequency is not passed and that
should make the kernel work with all versions of U-Boot.
Thanks,
Sekhar
> ---
> arch/arm/boot/dts/da850-evm.dts | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index f712fb6..c359872 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -22,9 +22,11 @@
> status = "okay";
> };
> serial1: serial@1d0c000 {
> + clock-frequency = <132000000>;
> status = "okay";
> };
> serial2: serial@1d0d000 {
> + clock-frequency = <132000000>;
> status = "okay";
> };
> rtc0: rtc@1c23000 {
>
next prev parent reply other threads:[~2013-02-28 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 8:32 [PATCH] ARM: davinci: da850 evm: update clock rate for UART 1/2 DT nodes Manjunathappa, Prakash
2013-02-19 8:32 ` Manjunathappa, Prakash
2013-02-28 10:39 ` Sekhar Nori [this message]
2013-02-28 10:39 ` Sekhar Nori
2013-03-15 13:26 ` Manjunathappa, Prakash
2013-03-15 13:26 ` Manjunathappa, Prakash
2013-03-15 14:37 ` Sekhar Nori
2013-03-15 14:37 ` Sekhar Nori
2013-04-09 5:31 ` Manjunathappa, Prakash
2013-04-09 5:31 ` Manjunathappa, Prakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F33F3.9070203@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.