* [PATCH v2] mmc: davinci: allow driver to work without DMA resource
@ 2013-02-05 12:22 Manjunathappa, Prakash
2013-02-22 13:03 ` Manjunathappa, Prakash
2013-02-28 11:00 ` Sekhar Nori
0 siblings, 2 replies; 4+ messages in thread
From: Manjunathappa, Prakash @ 2013-02-05 12:22 UTC (permalink / raw)
To: linux-mmc
Cc: cjb, davinci-linux-open-source, mporter, ido, gregkh,
Manjunathappa, Prakash
Do not return probe failure with missing DMA resources,
allow driver to work in PIO mode.
Tested on da850-evm by mounting partition followed by
file creation and deletion.
Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
---
Since v1:
Specified missing DMA resource(RX/TX).
drivers/mmc/host/davinci_mmc.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index 2063677..27123f8 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1190,13 +1190,15 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
if (!r)
- goto out;
- host->rxdma = r->start;
+ dev_warn(&pdev->dev, "RX DMA resource not specified\n");
+ else
+ host->rxdma = r->start;
r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
if (!r)
- goto out;
- host->txdma = r->start;
+ dev_warn(&pdev->dev, "TX DMA resource not specified\n");
+ else
+ host->txdma = r->start;
host->mem_res = mem;
host->base = ioremap(mem->start, mem_size);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH v2] mmc: davinci: allow driver to work without DMA resource
2013-02-05 12:22 [PATCH v2] mmc: davinci: allow driver to work without DMA resource Manjunathappa, Prakash
@ 2013-02-22 13:03 ` Manjunathappa, Prakash
2013-02-28 11:00 ` Sekhar Nori
1 sibling, 0 replies; 4+ messages in thread
From: Manjunathappa, Prakash @ 2013-02-22 13:03 UTC (permalink / raw)
To: Manjunathappa, Prakash, linux-mmc@vger.kernel.org
Cc: cjb@laptop.org, davinci-linux-open-source@linux.davincidsp.com,
Porter, Matt, ido@wizery.com, gregkh@linuxfoundation.org
Hi Chris,
As there are no comments, Could you please accept this patch?
Thanks,
Prakash
On Tue, Feb 05, 2013 at 17:52:24, Manjunathappa, Prakash wrote:
> Do not return probe failure with missing DMA resources,
> allow driver to work in PIO mode.
> Tested on da850-evm by mounting partition followed by
> file creation and deletion.
>
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> ---
> Since v1:
> Specified missing DMA resource(RX/TX).
>
> drivers/mmc/host/davinci_mmc.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index 2063677..27123f8 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -1190,13 +1190,15 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
>
> r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
> if (!r)
> - goto out;
> - host->rxdma = r->start;
> + dev_warn(&pdev->dev, "RX DMA resource not specified\n");
> + else
> + host->rxdma = r->start;
>
> r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
> if (!r)
> - goto out;
> - host->txdma = r->start;
> + dev_warn(&pdev->dev, "TX DMA resource not specified\n");
> + else
> + host->txdma = r->start;
>
> host->mem_res = mem;
> host->base = ioremap(mem->start, mem_size);
> --
> 1.7.4.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mmc: davinci: allow driver to work without DMA resource
2013-02-05 12:22 [PATCH v2] mmc: davinci: allow driver to work without DMA resource Manjunathappa, Prakash
2013-02-22 13:03 ` Manjunathappa, Prakash
@ 2013-02-28 11:00 ` Sekhar Nori
2013-03-22 16:05 ` Chris Ball
1 sibling, 1 reply; 4+ messages in thread
From: Sekhar Nori @ 2013-02-28 11:00 UTC (permalink / raw)
To: Manjunathappa, Prakash
Cc: linux-mmc, mporter, davinci-linux-open-source, gregkh, cjb
On 2/5/2013 5:52 PM, Manjunathappa, Prakash wrote:
> Do not return probe failure with missing DMA resources,
> allow driver to work in PIO mode.
> Tested on da850-evm by mounting partition followed by
> file creation and deletion.
>
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
I verified this along with your other patches enabling use of MMC with
DT boot.
Tested-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mmc: davinci: allow driver to work without DMA resource
2013-02-28 11:00 ` Sekhar Nori
@ 2013-03-22 16:05 ` Chris Ball
0 siblings, 0 replies; 4+ messages in thread
From: Chris Ball @ 2013-03-22 16:05 UTC (permalink / raw)
To: Sekhar Nori
Cc: Manjunathappa, Prakash, linux-mmc, mporter,
davinci-linux-open-source, gregkh
Hi,
On Thu, Feb 28 2013, Sekhar Nori wrote:
> On 2/5/2013 5:52 PM, Manjunathappa, Prakash wrote:
>> Do not return probe failure with missing DMA resources,
>> allow driver to work in PIO mode.
>> Tested on da850-evm by mounting partition followed by
>> file creation and deletion.
>>
>> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
>
> I verified this along with your other patches enabling use of MMC with
> DT boot.
>
> Tested-by: Sekhar Nori <nsekhar@ti.com>
Thanks, pushed to mmc-next for 3.10.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-22 16:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-05 12:22 [PATCH v2] mmc: davinci: allow driver to work without DMA resource Manjunathappa, Prakash
2013-02-22 13:03 ` Manjunathappa, Prakash
2013-02-28 11:00 ` Sekhar Nori
2013-03-22 16:05 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.