From: Jiri Slaby <jslaby@suse.cz>
To: Chen Gang <gang.chen@asianux.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
isdn@linux-pingi.de, Greg KH <gregkh@linuxfoundation.org>,
alan@linux.intel.com, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] drivers/isdn: checkng length to be sure not memory overflow
Date: Thu, 28 Feb 2013 14:43:48 +0100 [thread overview]
Message-ID: <512F5F14.6070801@suse.cz> (raw)
In-Reply-To: <512F38F8.2060804@asianux.com>
On 02/28/2013 12:01 PM, Chen Gang wrote:
> 于 2013年02月28日 18:00, Jiri Slaby 写道:
>> I don't think there are piles of people to care about ISDN much nowadays.
>
> I don't think either.
> (I found it through reading the source code, by search strncpy)
>
> if this is quite minor:
> I suggest to delete this module.
Nah, there *are* still people using ISDN.
>> So we can
>> close that it is correct to drop the rest of the buffer. In a hope that
>> +M is not followed by text longer than 50-or-so chars.
>
> can we be sure that "+M..." is no more than 100+ chars ?
> (I guess the sizeof (isdn_ctrl.parm) is 80+, but less than 100)
> if we can not be sure:
No, we cannot be sure that a user gives us less than that. Your patch
just throws the rest to fix that overflow, right? What I'm saying I
wouldn't fix more than that.
--
js
suse labs
next prev parent reply other threads:[~2013-02-28 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 9:05 [PATCH] drivers/isdn: checkng length to be sure not memory overflow Chen Gang
2013-02-27 9:48 ` Jiri Slaby
2013-02-27 10:25 ` Chen Gang
2013-02-27 10:44 ` Jiri Slaby
2013-02-28 1:45 ` Chen Gang
2013-02-28 10:00 ` Jiri Slaby
2013-02-28 11:01 ` Chen Gang
2013-02-28 13:43 ` Jiri Slaby [this message]
2013-03-05 2:20 ` Chen Gang
2013-03-05 9:34 ` Jiri Slaby
2013-03-07 4:13 ` Chen Gang
2013-03-08 4:25 ` [PATCH v2] " Chen Gang
2013-03-08 5:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F5F14.6070801@suse.cz \
--to=jslaby@suse.cz \
--cc=alan@linux.intel.com \
--cc=gang.chen@asianux.com \
--cc=gregkh@linuxfoundation.org \
--cc=isdn@linux-pingi.de \
--cc=jkosina@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.