From: Chen Gang <gang.chen@asianux.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Jiri Kosina <jkosina@suse.cz>,
isdn@linux-pingi.de, Greg KH <gregkh@linuxfoundation.org>,
alan@linux.intel.com, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] drivers/isdn: checkng length to be sure not memory overflow
Date: Thu, 07 Mar 2013 12:13:41 +0800 [thread overview]
Message-ID: <513813F5.5040806@asianux.com> (raw)
In-Reply-To: <5135BC3F.8070507@suse.cz>
于 2013年03月05日 17:34, Jiri Slaby 写道:
>> what you said is: this patch need improving, is it correct ?
>> > if it is correct.
>> > I still prefer to throw the rest contents (but need improving, too)
>> > for maintaining, we need fix bug, but not need add new features
>> > so what we should do:
>> > a) fix the bug (should not memory overflow)
>> > b) keep the original buffer length no touch
>> > it is not sizeof(cmd.parm.cmsg.para) - 2)
>> > it should be sizeof(cmd.param) - sizeof(cmd.param.cmsg) + sizeof(cmd.param.cmsg.para) - 2
>> > c) need complete the relative document to export the limitation.
>> >
>> > is it ok ?
> Yes, it is -- just fix the bug with minimal effort.
ok, I will send patch v2 for it.
:-)
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-03-07 4:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 9:05 [PATCH] drivers/isdn: checkng length to be sure not memory overflow Chen Gang
2013-02-27 9:48 ` Jiri Slaby
2013-02-27 10:25 ` Chen Gang
2013-02-27 10:44 ` Jiri Slaby
2013-02-28 1:45 ` Chen Gang
2013-02-28 10:00 ` Jiri Slaby
2013-02-28 11:01 ` Chen Gang
2013-02-28 13:43 ` Jiri Slaby
2013-03-05 2:20 ` Chen Gang
2013-03-05 9:34 ` Jiri Slaby
2013-03-07 4:13 ` Chen Gang [this message]
2013-03-08 4:25 ` [PATCH v2] " Chen Gang
2013-03-08 5:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513813F5.5040806@asianux.com \
--to=gang.chen@asianux.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=isdn@linux-pingi.de \
--cc=jkosina@suse.cz \
--cc=jslaby@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.