From: Vlad Yasevich <vyasevich@gmail.com>
To: "Lee A. Roberts" <lee.roberts@hp.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH v3 0/4] sctp: fix association hangs due to reassembly/ordering logic
Date: Thu, 28 Feb 2013 15:07:39 +0000 [thread overview]
Message-ID: <512F72BB.30909@gmail.com> (raw)
In-Reply-To: <1362062250-26749-1-git-send-email-lee.roberts@hp.com>
On 02/28/2013 09:37 AM, Lee A. Roberts wrote:
> From: "Lee A. Roberts" <lee.roberts@hp.com>
>
> This series of patches resolves several SCTP association hangs observed during
> SCTP stress testing. Observable symptoms include communications hangs with
> data being held in the association reassembly and/or lobby (ordering) queues.
> Close examination of reassembly/ordering queues may show either duplicated
> or missing packets.
>
> In version #2, corrected build failure in initial version of patch series
> due to wrong calling sequence for sctp_ulpq_partial_delivery() being inserted
> in sctp_ulpq_renege().
>
> In version #3, adjusted patch documentation to be less repetitive.
My Acks from version 1 still apply.
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
-vlad
>
> Lee A. Roberts (4):
> sctp: fix association hangs due to off-by-one errors in
> sctp_tsnmap_grow()
> sctp: fix association hangs due to reneging packets below the
> cumulative TSN ACK point
> sctp: fix association hangs due to errors when reneging events from
> the ordering queue
> sctp: fix association hangs due to partial delivery errors
>
> net/sctp/tsnmap.c | 13 ++++----
> net/sctp/ulpqueue.c | 87 +++++++++++++++++++++++++++++++++++++++++----------
> 2 files changed, 78 insertions(+), 22 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vyasevich@gmail.com>
To: "Lee A. Roberts" <lee.roberts@hp.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH v3 0/4] sctp: fix association hangs due to reassembly/ordering logic
Date: Thu, 28 Feb 2013 10:07:39 -0500 [thread overview]
Message-ID: <512F72BB.30909@gmail.com> (raw)
In-Reply-To: <1362062250-26749-1-git-send-email-lee.roberts@hp.com>
On 02/28/2013 09:37 AM, Lee A. Roberts wrote:
> From: "Lee A. Roberts" <lee.roberts@hp.com>
>
> This series of patches resolves several SCTP association hangs observed during
> SCTP stress testing. Observable symptoms include communications hangs with
> data being held in the association reassembly and/or lobby (ordering) queues.
> Close examination of reassembly/ordering queues may show either duplicated
> or missing packets.
>
> In version #2, corrected build failure in initial version of patch series
> due to wrong calling sequence for sctp_ulpq_partial_delivery() being inserted
> in sctp_ulpq_renege().
>
> In version #3, adjusted patch documentation to be less repetitive.
My Acks from version 1 still apply.
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
-vlad
>
> Lee A. Roberts (4):
> sctp: fix association hangs due to off-by-one errors in
> sctp_tsnmap_grow()
> sctp: fix association hangs due to reneging packets below the
> cumulative TSN ACK point
> sctp: fix association hangs due to errors when reneging events from
> the ordering queue
> sctp: fix association hangs due to partial delivery errors
>
> net/sctp/tsnmap.c | 13 ++++----
> net/sctp/ulpqueue.c | 87 +++++++++++++++++++++++++++++++++++++++++----------
> 2 files changed, 78 insertions(+), 22 deletions(-)
>
next prev parent reply other threads:[~2013-02-28 15:07 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 14:36 [PATCH 0/4] sctp: fix association hangs due to reassembly/ordering logic Lee A. Roberts
2013-02-26 14:36 ` [PATCH 1/4] sctp: fix association hangs due to off-by-one errors in sctp_tsnmap_grow() Lee A. Roberts
2013-02-27 13:52 ` Vlad Yasevich
2013-02-26 14:36 ` [PATCH 2/4] sctp: fix association hangs due to reneging packets below the cumulative TSN ACK point Lee A. Roberts
2013-02-27 13:52 ` Vlad Yasevich
2013-02-26 14:36 ` [PATCH 3/4] sctp: fix association hangs due to errors when reneging events from the ordering queue Lee A. Roberts
2013-02-27 13:53 ` Vlad Yasevich
2013-02-26 14:36 ` [PATCH 4/4] sctp: fix association hangs due to partial delivery errors Lee A. Roberts
2013-02-27 2:34 ` Vlad Yasevich
2013-02-27 4:38 ` Roberts, Lee A.
2013-02-27 13:51 ` Vlad Yasevich
2013-02-27 13:53 ` Vlad Yasevich
2013-02-26 22:37 ` [PATCH 0/4] sctp: fix association hangs due to reassembly/ordering logic David Miller
2013-02-27 12:35 ` Neil Horman
2013-02-27 16:41 ` Sridhar Samudrala
2013-02-27 17:15 ` Neil Horman
2013-02-27 18:09 ` David Miller
2013-02-27 18:55 ` Roberts, Lee A.
2013-02-27 19:09 ` David Miller
2013-02-27 18:54 ` [PATCH v2 " Lee A. Roberts
2013-02-27 19:36 ` Daniel Borkmann
2013-02-27 19:36 ` Daniel Borkmann
2013-02-27 19:43 ` David Miller
2013-02-27 19:43 ` David Miller
2013-02-27 20:13 ` Vlad Yasevich
2013-02-27 20:24 ` David Miller
2013-02-27 20:49 ` Vlad Yasevich
2013-02-27 20:26 ` Roberts, Lee A.
2013-02-28 14:37 ` [PATCH v3 " Lee A. Roberts
2013-02-28 14:37 ` Lee A. Roberts
2013-02-28 15:07 ` Vlad Yasevich [this message]
2013-02-28 15:07 ` Vlad Yasevich
2013-02-28 20:36 ` David Miller
2013-02-28 20:36 ` David Miller
2013-02-28 14:37 ` [PATCH v3 1/4] sctp: fix association hangs due to off-by-one errors in sctp_tsnmap_grow() Lee A. Roberts
2013-02-28 14:37 ` Lee A. Roberts
2013-02-28 14:37 ` [PATCH v3 2/4] sctp: fix association hangs due to reneging packets below the cumulative TSN ACK poin Lee A. Roberts
2013-02-28 14:37 ` [PATCH v3 2/4] sctp: fix association hangs due to reneging packets below the cumulative TSN ACK point Lee A. Roberts
2013-02-28 14:37 ` [PATCH v3 3/4] sctp: fix association hangs due to errors when reneging events from the ordering queu Lee A. Roberts
2013-02-28 14:37 ` [PATCH v3 3/4] sctp: fix association hangs due to errors when reneging events from the ordering queue Lee A. Roberts
2013-02-28 14:37 ` [PATCH v3 4/4] sctp: fix association hangs due to partial delivery errors Lee A. Roberts
2013-02-28 14:37 ` Lee A. Roberts
2013-02-27 18:54 ` [PATCH v2 1/4] sctp: fix association hangs due to off-by-one errors in sctp_tsnmap_grow() Lee A. Roberts
2013-02-28 14:31 ` Neil Horman
2013-02-27 18:54 ` [PATCH v2 2/4] sctp: fix association hangs due to reneging packets below the cumulative TSN ACK point Lee A. Roberts
2013-02-28 14:33 ` Neil Horman
2013-02-27 18:54 ` [PATCH v2 3/4] sctp: fix association hangs due to errors when reneging events from the ordering queue Lee A. Roberts
2013-02-28 14:34 ` Neil Horman
2013-02-27 18:54 ` [PATCH v2 4/4] sctp: fix association hangs due to partial delivery errors Lee A. Roberts
2013-02-28 14:34 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F72BB.30909@gmail.com \
--to=vyasevich@gmail.com \
--cc=lee.roberts@hp.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.