From: Juergen Gross <juergen.gross@ts.fujitsu.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] Rename credit2 names to csched2_*
Date: Fri, 01 Mar 2013 07:06:02 +0100 [thread overview]
Message-ID: <5130454A.9090802@ts.fujitsu.com> (raw)
In-Reply-To: <512E0D9A02000078000C17E2@nat28.tlf.novell.com>
On 27.02.2013 13:43, Jan Beulich wrote:
>>>> On 27.02.13 at 13:19, Juergen Gross<juergen.gross@ts.fujitsu.com> wrote:
>> Functions, variables, structures and macros in the credit2 scheduler had
>> partially the same names as in the credit scheduler. This makes it hard to
>> find the correct functions in backtraces or cscope.
>>
>> Rename all names in credit2 from csched_*/CSCHED_* to csched2_*/CSCHED2_*
>
> I don't think this is a suitable approach - if anything, we should aim
> at having printed static symbols (in backtraces etc) prefixed with
> their source file name. I would even question quite a few of the
> csched_ prefixes in credit1...
Just one other thought: unique names would help for analyzing crash dumps, too.
Juergen
--
Juergen Gross Principal Developer Operating Systems
PBG PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html
next prev parent reply other threads:[~2013-03-01 6:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 12:19 [PATCH] Rename credit2 names to csched2_* Juergen Gross
2013-02-27 12:43 ` Jan Beulich
2013-03-01 6:06 ` Juergen Gross [this message]
2013-03-01 8:20 ` Jan Beulich
2013-03-01 8:47 ` Juergen Gross
2013-03-01 10:38 ` Andrew Cooper
2013-03-01 11:36 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130454A.9090802@ts.fujitsu.com \
--to=juergen.gross@ts.fujitsu.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.