Re: [Qemu-trivial] [PATCH] pci_host: Drop write-only address_space field

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-trivial] [PATCH] pci_host: Drop write-only address_space field
Date: Fri, 01 Mar 2013 19:57:54 +0100	[thread overview]
Message-ID: <5130FA32.1070107@suse.de> (raw)
In-Reply-To: <CAFEAcA8x0K5s5FVqaLg-kaoSvZoHQK08OANj7Ax4FcQksLHWVw@mail.gmail.com>

Am 01.03.2013 19:50, schrieb Peter Maydell:
> On 1 March 2013 18:33, Andreas Färber <afaerber@suse.de> wrote:
>> Am 01.03.2013 17:57, schrieb Peter Maydell:
>>> The address_space field of PCIHostState was only ever written, never used.
>>> Drop it completely.
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Incidentally I suspect you could if you liked get rid of all
> the uses of PCIHostState in prep.c (and the #include of pci_host.h),
> since it's now only using &pcihost->busdev as an opaque way of
> saying SYS_BUS_DEVICE(dev)).

I believe I do have PCI_DEVICE() and ISA_BUS() changes in my tree. :)

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

WARNING: multiple messages have this Message-ID (diff)

From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] pci_host: Drop write-only address_space field
Date: Fri, 01 Mar 2013 19:57:54 +0100	[thread overview]
Message-ID: <5130FA32.1070107@suse.de> (raw)
In-Reply-To: <CAFEAcA8x0K5s5FVqaLg-kaoSvZoHQK08OANj7Ax4FcQksLHWVw@mail.gmail.com>

Am 01.03.2013 19:50, schrieb Peter Maydell:
> On 1 March 2013 18:33, Andreas Färber <afaerber@suse.de> wrote:
>> Am 01.03.2013 17:57, schrieb Peter Maydell:
>>> The address_space field of PCIHostState was only ever written, never used.
>>> Drop it completely.
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Incidentally I suspect you could if you liked get rid of all
> the uses of PCIHostState in prep.c (and the #include of pci_host.h),
> since it's now only using &pcihost->busdev as an opaque way of
> saying SYS_BUS_DEVICE(dev)).

I believe I do have PCI_DEVICE() and ISA_BUS() changes in my tree. :)

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

next prev parent reply	other threads:[~2013-03-01 18:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01 16:57 [Qemu-trivial] [PATCH] pci_host: Drop write-only address_space field Peter Maydell
2013-03-01 16:57 ` [Qemu-devel] " Peter Maydell
2013-03-01 18:33 ` [Qemu-trivial] " Andreas Färber
2013-03-01 18:33   ` [Qemu-devel] " Andreas Färber
2013-03-01 18:50   ` [Qemu-trivial] " Peter Maydell
2013-03-01 18:50     ` [Qemu-devel] " Peter Maydell
2013-03-01 18:57     ` Andreas Färber [this message]
2013-03-01 18:57       ` Andreas Färber
2013-03-04 10:58 ` [Qemu-trivial] " Stefan Hajnoczi
2013-03-04 10:58   ` [Qemu-devel] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5130FA32.1070107@suse.de \
    --to=afaerber@suse.de \
    --cc=mst@redhat.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.