From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>,
Fabio Estevam
<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>,
Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 3/8] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to System Reset Controller (SRC)
Date: Fri, 01 Mar 2013 13:07:20 -0700 [thread overview]
Message-ID: <51310A78.1020104@wwwdotorg.org> (raw)
In-Reply-To: <51310A12.1040209-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On 03/01/2013 01:05 PM, Stephen Warren wrote:
> On 02/26/2013 04:39 AM, Philipp Zabel wrote:
>> The SRC has auto-deasserting reset bits that control reset lines to
>> the GPU, VPU, IPU, and OpenVG IP modules. This patch adds a reset
>> controller that can be controlled by those devices using the
>> reset controller API.
>
>> diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.txt b/Documentation/devicetree/bindings/reset/fsl,imx-src.txt
>
>> +Specifying reset lines connected to IP modules
>> +==============================================
> ...
>> +example:
>> +
>> + ipu1: ipu@02400000 {
>> + resets = <&src 2>;
>> + };
>> + ipu2: ipu@02800000 {
>> + resets = <&src 4>;
>> + };
>
> reset-names is mandatory in the documentation and implementation; you
> should probably add them to the example too.
Oh, looking at the code further, I see reset-names is optional if the
client node only has one reset defined. So ignore my comment above.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/8] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to System Reset Controller (SRC)
Date: Fri, 01 Mar 2013 13:07:20 -0700 [thread overview]
Message-ID: <51310A78.1020104@wwwdotorg.org> (raw)
In-Reply-To: <51310A12.1040209@wwwdotorg.org>
On 03/01/2013 01:05 PM, Stephen Warren wrote:
> On 02/26/2013 04:39 AM, Philipp Zabel wrote:
>> The SRC has auto-deasserting reset bits that control reset lines to
>> the GPU, VPU, IPU, and OpenVG IP modules. This patch adds a reset
>> controller that can be controlled by those devices using the
>> reset controller API.
>
>> diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.txt b/Documentation/devicetree/bindings/reset/fsl,imx-src.txt
>
>> +Specifying reset lines connected to IP modules
>> +==============================================
> ...
>> +example:
>> +
>> + ipu1: ipu at 02400000 {
>> + resets = <&src 2>;
>> + };
>> + ipu2: ipu at 02800000 {
>> + resets = <&src 4>;
>> + };
>
> reset-names is mandatory in the documentation and implementation; you
> should probably add them to the example too.
Oh, looking at the code further, I see reset-names is optional if the
client node only has one reset defined. So ignore my comment above.
next prev parent reply other threads:[~2013-03-01 20:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 11:39 [PATCH v4 0/8] Reset controller API to reset IP modules on i.MX5 and i.MX6 Philipp Zabel
2013-02-26 11:39 ` Philipp Zabel
2013-02-26 11:39 ` [PATCH v4 1/8] dt: describe base reset signal binding Philipp Zabel
2013-02-26 11:39 ` Philipp Zabel
2013-02-26 11:39 ` [PATCH v4 2/8] reset: Add reset controller API Philipp Zabel
2013-02-26 11:39 ` Philipp Zabel
[not found] ` <1361878774-6382-3-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-01 20:00 ` Stephen Warren
2013-03-01 20:00 ` Stephen Warren
2013-03-04 8:33 ` Philipp Zabel
2013-03-04 8:33 ` Philipp Zabel
2013-03-04 17:03 ` Stephen Warren
2013-03-04 17:03 ` Stephen Warren
2013-02-26 11:39 ` [PATCH v4 3/8] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to System Reset Controller (SRC) Philipp Zabel
2013-02-26 11:39 ` Philipp Zabel
2013-03-01 20:05 ` Stephen Warren
2013-03-01 20:05 ` Stephen Warren
[not found] ` <51310A12.1040209-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-01 20:07 ` Stephen Warren [this message]
2013-03-01 20:07 ` Stephen Warren
2013-02-26 11:39 ` [PATCH v4 4/8] ARM i.MX6q: Link system reset controller (SRC) to IPU in DT Philipp Zabel
2013-02-26 11:39 ` Philipp Zabel
2013-02-26 11:39 ` [PATCH v4 5/8] staging: drm/imx: Use SRC to reset IPU Philipp Zabel
2013-02-26 11:39 ` Philipp Zabel
2013-02-26 11:39 ` [PATCH v4 6/8] ARM i.MX5: Add System Reset Controller (SRC) support for i.MX51 and i.MX53 Philipp Zabel
2013-02-26 11:39 ` Philipp Zabel
2013-02-26 11:39 ` [PATCH v4 7/8] ARM i.MX5: Add system reset controller (SRC) to i.MX51 and i.MX53 device tree Philipp Zabel
2013-02-26 11:39 ` Philipp Zabel
2013-02-26 11:39 ` [PATCH v4 8/8] reset: Add driver for gpio-controlled reset pins Philipp Zabel
2013-02-26 11:39 ` Philipp Zabel
2013-03-01 20:13 ` Stephen Warren
2013-03-01 20:13 ` Stephen Warren
2013-05-27 16:25 ` Fabio Estevam
2013-05-27 16:25 ` Fabio Estevam
2013-05-28 15:05 ` Philipp Zabel
2013-05-28 15:05 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51310A78.1020104@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.