Re: [Qemu-devel] [PATCH V7 08/14] qmp: add interface query-images.

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

>>>    
>>>    ##
>>> +# @query-images:
>>> +#
>>> +# Get a list of DeviceImageInfo for all virtual block devices.
>>
>> # Get block device image information
>>
>    OK.
> 
>>> +#
>>> +# @device: #optional the name of the device to get image info from. If not
>>> +#          specified, all block devices will be queried
>>> +# @backing: #optional true to show information on backing images, false or
>>> +#          omitted to show just the top image of a block device
>>
>> I'm not sure these flags are necessary.
>>
>    These flag seems more flex to me. Always querying all info require
> caller do a filter operation on what he got, but in many times caller
> may be interested on only one device.
>
  Coding for next version, I still feel flag may bring flexbility.
Markus, are u OK with this?


>>> +#
>>> +# Returns: a list of @DeviceImageInfo describing each virtual block device
>>> +#
>>> +# Since: 1.5
>>> +##
>>> +{ 'command': 'query-images',
>>> +  'data': { '*device': 'str', '*backing': 'bool' },
>>> +  'returns': ['DeviceImageInfo'] }
>>> +



-- 
Best Regards

Wenchao Xia