From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
lcapitulino@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c
Date: Tue, 05 Mar 2013 11:52:36 +0100 [thread overview]
Message-ID: <5135CE74.7020703@redhat.com> (raw)
In-Reply-To: <20130305100838.GB3450@dhcp-200-207.str.redhat.com>
Il 05/03/2013 11:08, Kevin Wolf ha scritto:
>> >
>> > As discussed on IRC, it's fine by me. If a better way to organize these
>> > functions becomes clear in the future they can be moved.
> As also discussed on IRC, I'm not excited by having a block/misc.c. We
> already have something for "everything block related that doesn't fit
> elsewhere" and it's block.c. I couldn't tell if a function belong into
> block.c or block/misc.c.
>
> I suggested having a file that concentrates all function related to
> QAPI, the monitor and JSON (including the qemu-img JSON output) and call
> it something like block/qapi.c (I'm open for better suggestions). This
> would at least make it clear if a function should be in there or not.
I agree with Kevin.
Paolo
next prev parent reply other threads:[~2013-03-05 10:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1361875228-15769-1-git-send-email-xiawenc@linux.vnet.ibm.com>
[not found] ` <1361875228-15769-9-git-send-email-xiawenc@linux.vnet.ibm.com>
[not found] ` <878v69hhl5.fsf@blackfin.pond.sub.org>
[not found] ` <512EBD01.8010906@linux.vnet.ibm.com>
2013-03-04 2:30 ` [Qemu-devel] [PATCH V7 08/14] qmp: add interface query-images Wenchao Xia
[not found] ` <1361875228-15769-10-git-send-email-xiawenc@linux.vnet.ibm.com>
[not found] ` <874ngxhhfv.fsf@blackfin.pond.sub.org>
[not found] ` <20130227162229.GJ2514@dhcp-200-207.str.redhat.com>
[not found] ` <513009B9.4090406@linux.vnet.ibm.com>
2013-03-04 3:20 ` [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c Wenchao Xia
2013-03-04 13:02 ` Stefan Hajnoczi
2013-03-05 7:11 ` Wenchao Xia
2013-03-05 9:21 ` Stefan Hajnoczi
2013-03-05 10:08 ` Kevin Wolf
2013-03-05 10:52 ` Paolo Bonzini [this message]
[not found] ` <20130228155702.GJ18389@stefanha-thinkpad.redhat.com>
[not found] ` <513008B1.8080605@linux.vnet.ibm.com>
2013-03-04 13:10 ` [Qemu-devel] [PATCH V7 00/14] add qmp/hmp interfaces for internal snapshot info Stefan Hajnoczi
2013-03-05 0:43 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5135CE74.7020703@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.