From: Jon Hunter <jon-hunter@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Felipe Balbi <balbi@ti.com>, Afzal Mohammed <afzal@ti.com>
Subject: Re: [PATCH v3 0/8] ARM: omap2: GPMC cleanup
Date: Mon, 4 Mar 2013 13:25:32 -0600 [thread overview]
Message-ID: <5134F52C.1010300@ti.com> (raw)
In-Reply-To: <20130304185259.GQ11806@atomide.com>
On 03/04/2013 12:53 PM, Tony Lindgren wrote:
> * Ezequiel Garcia <ezequiel.garcia@free-electrons.com> [130212 11:26]:
>> This patchset is v3 of the small cleanup consisting in:
>> * mark some functions as 'static' when appropriate
>> * remove an unused function from gpmc.c
>> * improve error messages when a CS request fails
>> * migrate to dev_err and dev_warn
>>
>> Changes from v2:
>> * add a commit message to some trivial patches,
>> that omitted it due to author's laziness.
>>
>> Changes from v1:
>> * fix gpmc_cs_reserved to return a boolean instead
>> of an integer error code
>> * add a new patch to the patchset cleaning redundant checks
>>
>> It has been tested on a IGEP v2 board with OneNAND,
>> which means the gpmc-nand patch is tested by compilation only.
>>
>> Altough this patchset is almost trivial,
>> any feedback or testing is more than welcome.
>>
>> Thanks to Jon Hunter for his kind review!
>
> Looks good to me. Jon, can you please queue all the GPMC related
> patches into one pull request around -rc2 time assuming no more
> comments?
Yes will do.
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/8] ARM: omap2: GPMC cleanup
Date: Mon, 4 Mar 2013 13:25:32 -0600 [thread overview]
Message-ID: <5134F52C.1010300@ti.com> (raw)
In-Reply-To: <20130304185259.GQ11806@atomide.com>
On 03/04/2013 12:53 PM, Tony Lindgren wrote:
> * Ezequiel Garcia <ezequiel.garcia@free-electrons.com> [130212 11:26]:
>> This patchset is v3 of the small cleanup consisting in:
>> * mark some functions as 'static' when appropriate
>> * remove an unused function from gpmc.c
>> * improve error messages when a CS request fails
>> * migrate to dev_err and dev_warn
>>
>> Changes from v2:
>> * add a commit message to some trivial patches,
>> that omitted it due to author's laziness.
>>
>> Changes from v1:
>> * fix gpmc_cs_reserved to return a boolean instead
>> of an integer error code
>> * add a new patch to the patchset cleaning redundant checks
>>
>> It has been tested on a IGEP v2 board with OneNAND,
>> which means the gpmc-nand patch is tested by compilation only.
>>
>> Altough this patchset is almost trivial,
>> any feedback or testing is more than welcome.
>>
>> Thanks to Jon Hunter for his kind review!
>
> Looks good to me. Jon, can you please queue all the GPMC related
> patches into one pull request around -rc2 time assuming no more
> comments?
Yes will do.
Jon
next prev parent reply other threads:[~2013-03-04 19:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 19:22 [PATCH v3 0/8] ARM: omap2: GPMC cleanup Ezequiel Garcia
2013-02-12 19:22 ` Ezequiel Garcia
2013-02-12 19:22 ` [PATCH v3 1/8] ARM: omap2: gpmc: Mark local scoped functions static Ezequiel Garcia
2013-02-12 19:22 ` Ezequiel Garcia
2013-02-12 19:22 ` [PATCH v3 2/8] ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function Ezequiel Garcia
2013-02-12 19:22 ` Ezequiel Garcia
2013-02-12 19:22 ` [PATCH v3 3/8] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value Ezequiel Garcia
2013-02-12 19:22 ` Ezequiel Garcia
2013-02-12 19:22 ` [PATCH v3 4/8] ARM: omap2: gpmc-nand: Print something useful on CS request failure Ezequiel Garcia
2013-02-12 19:22 ` Ezequiel Garcia
2013-02-12 19:22 ` [PATCH v3 5/8] ARM: omap2: gpmc-onenand: " Ezequiel Garcia
2013-02-12 19:22 ` Ezequiel Garcia
2013-02-12 19:22 ` [PATCH v3 6/8] ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err() Ezequiel Garcia
2013-02-12 19:22 ` Ezequiel Garcia
2013-02-12 19:22 ` [PATCH v3 7/8] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn() Ezequiel Garcia
2013-02-12 19:22 ` Ezequiel Garcia
2013-02-12 19:22 ` [PATCH v3 8/8] ARM: omap2: gpmc: Remove redundant chip select out of range check Ezequiel Garcia
2013-02-12 19:22 ` Ezequiel Garcia
2013-03-04 18:53 ` [PATCH v3 0/8] ARM: omap2: GPMC cleanup Tony Lindgren
2013-03-04 18:53 ` Tony Lindgren
2013-03-04 19:25 ` Jon Hunter [this message]
2013-03-04 19:25 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5134F52C.1010300@ti.com \
--to=jon-hunter@ti.com \
--cc=afzal@ti.com \
--cc=balbi@ti.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.