All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sata_fsl: Remove redundant NULL check before kfree
@ 2013-02-24 23:14 Syam Sidhardhan
  2013-03-04 22:15 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Syam Sidhardhan @ 2013-02-24 23:14 UTC (permalink / raw)
  To: linux-ide; +Cc: syamsidhardh, jgarzik

kfree on NULL pointer is a no-op.

Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
---
 drivers/ata/sata_fsl.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 124b2c1..608f82f 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1511,8 +1511,7 @@ error_exit_with_cleanup:
 
 	if (hcr_base)
 		iounmap(hcr_base);
-	if (host_priv)
-		kfree(host_priv);
+	kfree(host_priv);
 
 	return retval;
 }
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sata_fsl: Remove redundant NULL check before kfree
  2013-02-24 23:14 [PATCH] sata_fsl: Remove redundant NULL check before kfree Syam Sidhardhan
@ 2013-03-04 22:15 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2013-03-04 22:15 UTC (permalink / raw)
  To: Syam Sidhardhan; +Cc: linux-ide

On 02/24/2013 06:14 PM, Syam Sidhardhan wrote:
> kfree on NULL pointer is a no-op.
>
> Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
> ---
>   drivers/ata/sata_fsl.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

applied




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-04 22:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-24 23:14 [PATCH] sata_fsl: Remove redundant NULL check before kfree Syam Sidhardhan
2013-03-04 22:15 ` Jeff Garzik

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.