From: kishon <kishon@ti.com>
To: balbi@ti.com
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP: RX-51: add missing USB phy binding
Date: Tue, 5 Mar 2013 17:11:54 +0530 [thread overview]
Message-ID: <5135DA02.8070801@ti.com> (raw)
In-Reply-To: <20130305113618.GB19290@arwen.pp.htv.fi>
On Tuesday 05 March 2013 05:06 PM, Felipe Balbi wrote:
> On Tue, Mar 05, 2013 at 01:09:40PM +0200, Aaro Koskinen wrote:
>> Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to
>> add phy binding for RX-51, and as a result USB does not work anymore on
>> 3.9-rc1. Add the missing binding.
>>
>> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>
> Acked-by: Felipe Balbi <balbi@ti.com>
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
>
>> ---
>> arch/arm/mach-omap2/board-rx51.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c
>> index f7c4616..d2ea68e 100644
>> --- a/arch/arm/mach-omap2/board-rx51.c
>> +++ b/arch/arm/mach-omap2/board-rx51.c
>> @@ -17,6 +17,7 @@
>> #include <linux/io.h>
>> #include <linux/gpio.h>
>> #include <linux/leds.h>
>> +#include <linux/usb/phy.h>
>> #include <linux/usb/musb.h>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>>
>> @@ -98,6 +99,7 @@ static void __init rx51_init(void)
>> sdrc_params = nokia_get_sdram_timings();
>> omap_sdrc_init(sdrc_params, sdrc_params);
>>
>> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
>> usb_musb_init(&musb_board_data);
>> rx51_peripherals_init();
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (kishon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: RX-51: add missing USB phy binding
Date: Tue, 5 Mar 2013 17:11:54 +0530 [thread overview]
Message-ID: <5135DA02.8070801@ti.com> (raw)
In-Reply-To: <20130305113618.GB19290@arwen.pp.htv.fi>
On Tuesday 05 March 2013 05:06 PM, Felipe Balbi wrote:
> On Tue, Mar 05, 2013 at 01:09:40PM +0200, Aaro Koskinen wrote:
>> Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to
>> add phy binding for RX-51, and as a result USB does not work anymore on
>> 3.9-rc1. Add the missing binding.
>>
>> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>
> Acked-by: Felipe Balbi <balbi@ti.com>
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
>
>> ---
>> arch/arm/mach-omap2/board-rx51.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c
>> index f7c4616..d2ea68e 100644
>> --- a/arch/arm/mach-omap2/board-rx51.c
>> +++ b/arch/arm/mach-omap2/board-rx51.c
>> @@ -17,6 +17,7 @@
>> #include <linux/io.h>
>> #include <linux/gpio.h>
>> #include <linux/leds.h>
>> +#include <linux/usb/phy.h>
>> #include <linux/usb/musb.h>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>>
>> @@ -98,6 +99,7 @@ static void __init rx51_init(void)
>> sdrc_params = nokia_get_sdram_timings();
>> omap_sdrc_init(sdrc_params, sdrc_params);
>>
>> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
>> usb_musb_init(&musb_board_data);
>> rx51_peripherals_init();
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-03-05 11:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 11:09 [PATCH] ARM: OMAP: RX-51: add missing USB phy binding Aaro Koskinen
2013-03-05 11:09 ` Aaro Koskinen
2013-03-05 11:36 ` Felipe Balbi
2013-03-05 11:36 ` Felipe Balbi
2013-03-05 11:41 ` kishon [this message]
2013-03-05 11:41 ` kishon
2013-03-05 16:26 ` Tony Lindgren
2013-03-05 16:26 ` Tony Lindgren
2013-03-06 9:10 ` kishon
2013-03-06 9:10 ` kishon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5135DA02.8070801@ti.com \
--to=kishon@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.