From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/3] ARM: mach-shmobile: r8a7740: Setup the serial devices using DT
Date: Tue, 05 Mar 2013 13:42:31 +0000 [thread overview]
Message-ID: <5135F647.8050002@cogentembedded.com> (raw)
In-Reply-To: <CABYn4sx=bC6JwicbVgRnmwdu=6DuW5GFgdG25a-Wow1Jn9M-bQ@mail.gmail.com>
Hello.
On 05-03-2013 17:00, Bastian Hecht wrote:
>>> + sci@e6c40000 {
>>> + compatible = "renesas,sci-SCIFA-uart";
>>> + interrupt-parent = <&intca>;
>>> + reg = <0xe6c40000 0x100>;
>>> + interrupts = <0x0c00>, <0x0c00>, <0x0c00>, <0x0c00>;
>>> + cell-index = <0>;
>>> + renesas,scscr = <0x30>;
>>> + renesas,scbrr-algo-id = <4>;
>>> + renesas,autoconf;
>>> + };
>>
>> The default name for a uart is "serial", I would recommend sticking to
>> that by convention. You may also want to add an "aliases" node
>> somewhere, to define which port should get which logical device number
>> on a given board.
> Switched to "...-serial".
I think he was talking about the node name, not "compatible" property.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Bastian Hecht <hechtb@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
Paul Mundt <lethal@linux-sh.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v4 3/3] ARM: mach-shmobile: r8a7740: Setup the serial devices using DT
Date: Tue, 05 Mar 2013 17:42:31 +0400 [thread overview]
Message-ID: <5135F647.8050002@cogentembedded.com> (raw)
In-Reply-To: <CABYn4sx=bC6JwicbVgRnmwdu=6DuW5GFgdG25a-Wow1Jn9M-bQ@mail.gmail.com>
Hello.
On 05-03-2013 17:00, Bastian Hecht wrote:
>>> + sci@e6c40000 {
>>> + compatible = "renesas,sci-SCIFA-uart";
>>> + interrupt-parent = <&intca>;
>>> + reg = <0xe6c40000 0x100>;
>>> + interrupts = <0x0c00>, <0x0c00>, <0x0c00>, <0x0c00>;
>>> + cell-index = <0>;
>>> + renesas,scscr = <0x30>;
>>> + renesas,scbrr-algo-id = <4>;
>>> + renesas,autoconf;
>>> + };
>>
>> The default name for a uart is "serial", I would recommend sticking to
>> that by convention. You may also want to add an "aliases" node
>> somewhere, to define which port should get which logical device number
>> on a given board.
> Switched to "...-serial".
I think he was talking about the node name, not "compatible" property.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/3] ARM: mach-shmobile: r8a7740: Setup the serial devices using DT
Date: Tue, 05 Mar 2013 17:42:31 +0400 [thread overview]
Message-ID: <5135F647.8050002@cogentembedded.com> (raw)
In-Reply-To: <CABYn4sx=bC6JwicbVgRnmwdu=6DuW5GFgdG25a-Wow1Jn9M-bQ@mail.gmail.com>
Hello.
On 05-03-2013 17:00, Bastian Hecht wrote:
>>> + sci at e6c40000 {
>>> + compatible = "renesas,sci-SCIFA-uart";
>>> + interrupt-parent = <&intca>;
>>> + reg = <0xe6c40000 0x100>;
>>> + interrupts = <0x0c00>, <0x0c00>, <0x0c00>, <0x0c00>;
>>> + cell-index = <0>;
>>> + renesas,scscr = <0x30>;
>>> + renesas,scbrr-algo-id = <4>;
>>> + renesas,autoconf;
>>> + };
>>
>> The default name for a uart is "serial", I would recommend sticking to
>> that by convention. You may also want to add an "aliases" node
>> somewhere, to define which port should get which logical device number
>> on a given board.
> Switched to "...-serial".
I think he was talking about the node name, not "compatible" property.
WBR, Sergei
next prev parent reply other threads:[~2013-03-05 13:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 15:23 [PATCH v4 1/3] serial: sh-sci: Add OF support Bastian Hecht
2013-03-04 16:20 ` Bastian Hecht
2013-03-04 16:20 ` Bastian Hecht
2013-03-04 15:23 ` [PATCH v4 2/3] ARM: mach-shmobile: r8a7740: Add DT names to clock list Bastian Hecht
2013-03-04 16:20 ` Bastian Hecht
2013-03-04 16:20 ` Bastian Hecht
2013-03-04 15:29 ` [PATCH v4 3/3] ARM: mach-shmobile: r8a7740: Setup the serial devices using DT Bastian Hecht
2013-03-04 16:20 ` Bastian Hecht
2013-03-04 16:20 ` Bastian Hecht
2013-03-04 16:22 ` Arnd Bergmann
2013-03-04 16:22 ` Arnd Bergmann
2013-03-04 16:22 ` Arnd Bergmann
2013-03-05 13:00 ` Bastian Hecht
2013-03-05 13:00 ` Bastian Hecht
2013-03-05 13:00 ` Bastian Hecht
2013-03-05 13:42 ` Sergei Shtylyov [this message]
2013-03-05 13:42 ` Sergei Shtylyov
2013-03-05 13:42 ` Sergei Shtylyov
2013-03-05 13:47 ` Bastian Hecht
2013-03-05 13:47 ` Bastian Hecht
2013-03-05 13:47 ` Bastian Hecht
2013-03-05 19:22 ` Arnd Bergmann
2013-03-05 19:22 ` Arnd Bergmann
2013-03-05 19:22 ` Arnd Bergmann
2013-03-04 16:20 ` [PATCH v4 1/3] serial: sh-sci: Add OF support Arnd Bergmann
2013-03-04 16:20 ` Arnd Bergmann
2013-03-04 16:20 ` Arnd Bergmann
2013-03-05 12:58 ` Bastian Hecht
2013-03-05 12:58 ` Bastian Hecht
2013-03-05 12:58 ` Bastian Hecht
2013-03-05 19:26 ` Arnd Bergmann
2013-03-05 19:26 ` Arnd Bergmann
2013-03-05 19:26 ` Arnd Bergmann
2013-03-06 0:50 ` Paul Mundt
2013-03-06 0:50 ` Paul Mundt
2013-03-06 0:50 ` Paul Mundt
2013-03-06 10:19 ` Bastian Hecht
2013-03-06 10:19 ` Bastian Hecht
2013-03-06 10:19 ` Bastian Hecht
2013-03-06 10:28 ` Arnd Bergmann
2013-03-06 10:28 ` Arnd Bergmann
2013-03-06 10:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5135F647.8050002@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.