All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Vincent Yang <vincent.yang.fujitsu@gmail.com>
Cc: chris@printf.net, linux-mmc@vger.kernel.org, anton@enomsg.org,
	linuxppc-dev@lists.ozlabs.org, patches@linaro.org,
	andy.green@linaro.org, Vincent.Yang@tw.fujitsu.com
Subject: Re: [RFC PATCH 5/7] mmc: sdhci: host: add new f_sdh30
Date: Fri, 20 Jun 2014 12:00:40 +0200	[thread overview]
Message-ID: <5136245.WRbqGRMMHn@wuerfel> (raw)
In-Reply-To: <1403256928-11359-6-git-send-email-Vincent.Yang@tw.fujitsu.com>

On Friday 20 June 2014 17:35:26 Vincent Yang wrote:
> +Required properties:
> +- compatible: "fujitsu,f_sdh30"
> +
> +Optional properties:
> +- gpios: Specify gpios for controlling signal level
> +- clocks: Specify clocks used by SDHCI controller
> +- clock-names: Specify the clock-names to be used

If you want to use "clock-names", you have to specify the exact names
of the clock input signals used by your device, and the order in which
they are listed.

For both the clocks and the gpios, you have to specify how many signals
there are, and ideally describe what they are used for. In case of a
gpio controlling the signal level, it may be better to model this
as a gpio-regulator device, depending on how exactly it is used.

When posting a DT binding document, please always add
devicetree@vger.kernel.org to Cc.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Vincent Yang <vincent.yang.fujitsu@gmail.com>
Cc: andy.green@linaro.org, patches@linaro.org, anton@enomsg.org,
	linux-mmc@vger.kernel.org, chris@printf.net,
	Vincent.Yang@tw.fujitsu.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 5/7] mmc: sdhci: host: add new f_sdh30
Date: Fri, 20 Jun 2014 12:00:40 +0200	[thread overview]
Message-ID: <5136245.WRbqGRMMHn@wuerfel> (raw)
In-Reply-To: <1403256928-11359-6-git-send-email-Vincent.Yang@tw.fujitsu.com>

On Friday 20 June 2014 17:35:26 Vincent Yang wrote:
> +Required properties:
> +- compatible: "fujitsu,f_sdh30"
> +
> +Optional properties:
> +- gpios: Specify gpios for controlling signal level
> +- clocks: Specify clocks used by SDHCI controller
> +- clock-names: Specify the clock-names to be used

If you want to use "clock-names", you have to specify the exact names
of the clock input signals used by your device, and the order in which
they are listed.

For both the clocks and the gpios, you have to specify how many signals
there are, and ideally describe what they are used for. In case of a
gpio controlling the signal level, it may be better to model this
as a gpio-regulator device, depending on how exactly it is used.

When posting a DT binding document, please always add
devicetree@vger.kernel.org to Cc.

	Arnd

  reply	other threads:[~2014-06-20 10:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20  9:35 [RFC PATCH 0/7] mmc: sdhci: adding support for a new Fujitsu sdhci IP Vincent Yang
2014-06-20  9:35 ` Vincent Yang
2014-06-20  9:35 ` [RFC PATCH 1/7] mmc: sdhci: add quirk for broken 3.0V support Vincent Yang
2014-06-20  9:35   ` Vincent Yang
2014-06-20 20:26   ` Anton Vorontsov
2014-06-20 20:26     ` Anton Vorontsov
2014-06-21  4:29     ` Vincent Yang
2014-06-21  4:29       ` Vincent Yang
2014-06-20  9:35 ` [RFC PATCH 2/7] mmc: sdhci: add quirk for voltage switch callback Vincent Yang
2014-06-20  9:35   ` Vincent Yang
2014-06-20  9:35 ` [RFC PATCH 3/7] mmc: sdhci: add quirk for tuning work around Vincent Yang
2014-06-20  9:35   ` Vincent Yang
2014-06-20  9:35 ` [RFC PATCH 4/7] mmc: sdhci: add quirk for single block transactions Vincent Yang
2014-06-20  9:35   ` Vincent Yang
2014-06-20  9:35 ` [RFC PATCH 5/7] mmc: sdhci: host: add new f_sdh30 Vincent Yang
2014-06-20  9:35   ` Vincent Yang
2014-06-20 10:00   ` Arnd Bergmann [this message]
2014-06-20 10:00     ` Arnd Bergmann
2014-06-20 10:29     ` Vincent Yang
2014-06-20 10:29       ` Vincent Yang
2014-06-20  9:35 ` [RFC PATCH 6/7] mmc: core: hold SD Clock before CMD11 during Signal Voltage Switch Procedure Vincent Yang
2014-06-20  9:35   ` Vincent Yang
2014-06-20  9:35 ` [RFC PATCH 7/7] mmc: core: add manual resume capability Vincent Yang
2014-06-20  9:35   ` Vincent Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5136245.WRbqGRMMHn@wuerfel \
    --to=arnd@arndb.de \
    --cc=Vincent.Yang@tw.fujitsu.com \
    --cc=andy.green@linaro.org \
    --cc=anton@enomsg.org \
    --cc=chris@printf.net \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=patches@linaro.org \
    --cc=vincent.yang.fujitsu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.