All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gregungerer@westnet.com.au>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: drop "select EMAC_INC"
Date: Wed, 06 Mar 2013 16:10:07 +1000	[thread overview]
Message-ID: <5136DDBF.8090000@westnet.com.au> (raw)
In-Reply-To: <1362504650.16460.95.camel@x61.thuisdomein>

Hi Paul,

On 06/03/13 03:30, Paul Bolle wrote:
> Somehow this select statement managed to squeeze itself between commit
> 0e152d80507b75c00aac60f2ffc586360687cd52 ("m68k: reorganize Kconfig
> options to improve mmu/non-mmu selections") and commit
> 95e82747d6e2abc513bfae416e6009968985d05b ("m68k: drop unused Kconfig
> symbols"). Whatever happened, there is no Kconfig symbol named EMAC_INC.
> The select statement for that symbol is a nop. Drop it.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Thanks, I'll add that to the m68knommu git tree, since it is a non-mmu
target.

Regards
Greg


> Untested, but it's hard to see what can got wrong here.
>
>   arch/m68k/Kconfig.machine | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
> index 7cdf6b0..7240584 100644
> --- a/arch/m68k/Kconfig.machine
> +++ b/arch/m68k/Kconfig.machine
> @@ -310,7 +310,6 @@ config COBRA5282
>   config SOM5282EM
>   	bool "EMAC.Inc SOM5282EM board support"
>   	depends on M528x
> -	select EMAC_INC
>   	help
>   	  Support for the EMAC.Inc SOM5282EM module.
>
>

WARNING: multiple messages have this Message-ID (diff)
From: Greg Ungerer <gregungerer@westnet.com.au>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: drop "select EMAC_INC"
Date: Wed, 06 Mar 2013 16:10:07 +1000	[thread overview]
Message-ID: <5136DDBF.8090000@westnet.com.au> (raw)
In-Reply-To: <1362504650.16460.95.camel@x61.thuisdomein>

Hi Paul,

On 06/03/13 03:30, Paul Bolle wrote:
> Somehow this select statement managed to squeeze itself between commit
> 0e152d80507b75c00aac60f2ffc586360687cd52 ("m68k: reorganize Kconfig
> options to improve mmu/non-mmu selections") and commit
> 95e82747d6e2abc513bfae416e6009968985d05b ("m68k: drop unused Kconfig
> symbols"). Whatever happened, there is no Kconfig symbol named EMAC_INC.
> The select statement for that symbol is a nop. Drop it.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Thanks, I'll add that to the m68knommu git tree, since it is a non-mmu
target.

Regards
Greg


> Untested, but it's hard to see what can got wrong here.
>
>   arch/m68k/Kconfig.machine | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
> index 7cdf6b0..7240584 100644
> --- a/arch/m68k/Kconfig.machine
> +++ b/arch/m68k/Kconfig.machine
> @@ -310,7 +310,6 @@ config COBRA5282
>   config SOM5282EM
>   	bool "EMAC.Inc SOM5282EM board support"
>   	depends on M528x
> -	select EMAC_INC
>   	help
>   	  Support for the EMAC.Inc SOM5282EM module.
>
>


  reply	other threads:[~2013-03-06  6:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05 17:30 [PATCH] m68k: drop "select EMAC_INC" Paul Bolle
2013-03-06  6:10 ` Greg Ungerer [this message]
2013-03-06  6:10   ` Greg Ungerer
  -- strict thread matches above, loose matches on Subject: below --
2013-03-05 17:30 Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5136DDBF.8090000@westnet.com.au \
    --to=gregungerer@westnet.com.au \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.