From: Florian Fainelli <florian@openwrt.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kyungsik Lee <kyungsik.lee@lge.com>,
Russell King <linux@arm.linux.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
x86@kernel.org, celinux-dev@lists.celinuxforum.org,
Nicolas Pitre <nico@fluxnic.net>, David Sterba <dsterba@suse.cz>,
Nitin Gupta <nitingupta910@gmail.com>,
Joe Millenbach <jmillenbach@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michal Marek <mmarek@suse.cz>,
hyojun.im@lge.com, chan.jeong@lge.com,
raphael.andy.lee@gmail.com
Subject: Re: [PATCH v3 -next 5/5] Kconfig: Make x86 and arm kernels default to the LZ4-compressed
Date: Wed, 06 Mar 2013 10:57:52 +0100 [thread overview]
Message-ID: <51371320.6000002@openwrt.org> (raw)
In-Reply-To: <20130305150845.0d19a2875d39dac5d03b4b62@linux-foundation.org>
On 03/06/2013 12:08 AM, Andrew Morton wrote:
> On Tue, 05 Mar 2013 13:04:20 +0100 Florian Fainelli <florian@openwrt.org> wrote:
>
>> Hello,
>>
>> On 03/05/2013 12:47 PM, Kyungsik Lee wrote:
>>> This patch makes x86 and arm kernels default to the LZ4-compressed
>>> to test new LZ4 code in the linux-next. This is requested by
>>> Andrew Morton.
>>
>> I do not think making this the default is good idea, because the lz4demo
>> utility that you need to actually compress the kernel (used in patch 2)
>> is not installed nor available by default on most systems, while gzip
>> is.
>
> Yes, that's a showstopper even for linux-next. What a shame.
>
> It means this code will walk into mainline with practically zero
> third-party testing. Oh well, the risk is minor. If it breaks, people
> can switch back to gzip easily enough.
If we want to have more coverage, how about importing the lz4demo
utility source code to tools/lz4/, and change scripts/Makefile.lib to
point at it? Once the lz4 utilities have reached a broader audience and
are available with most distributions, we could revert back to assuming
this utility can be found in PATH.
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 -next 5/5] Kconfig: Make x86 and arm kernels default to the LZ4-compressed
Date: Wed, 06 Mar 2013 10:57:52 +0100 [thread overview]
Message-ID: <51371320.6000002@openwrt.org> (raw)
In-Reply-To: <20130305150845.0d19a2875d39dac5d03b4b62@linux-foundation.org>
On 03/06/2013 12:08 AM, Andrew Morton wrote:
> On Tue, 05 Mar 2013 13:04:20 +0100 Florian Fainelli <florian@openwrt.org> wrote:
>
>> Hello,
>>
>> On 03/05/2013 12:47 PM, Kyungsik Lee wrote:
>>> This patch makes x86 and arm kernels default to the LZ4-compressed
>>> to test new LZ4 code in the linux-next. This is requested by
>>> Andrew Morton.
>>
>> I do not think making this the default is good idea, because the lz4demo
>> utility that you need to actually compress the kernel (used in patch 2)
>> is not installed nor available by default on most systems, while gzip
>> is.
>
> Yes, that's a showstopper even for linux-next. What a shame.
>
> It means this code will walk into mainline with practically zero
> third-party testing. Oh well, the risk is minor. If it breaks, people
> can switch back to gzip easily enough.
If we want to have more coverage, how about importing the lz4demo
utility source code to tools/lz4/, and change scripts/Makefile.lib to
point at it? Once the lz4 utilities have reached a broader audience and
are available with most distributions, we could revert back to assuming
this utility can be found in PATH.
--
Florian
next prev parent reply other threads:[~2013-03-06 10:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 11:47 [PATCH v3 -next 0/5] Add support for LZ4-compressed kernel Kyungsik Lee
2013-03-05 11:47 ` Kyungsik Lee
2013-03-05 11:47 ` [PATCH v3 -next 1/5] decompressor: Add LZ4 decompressor module Kyungsik Lee
2013-03-05 11:47 ` Kyungsik Lee
2013-03-05 11:47 ` [PATCH v3 -next 2/5] lib: Add support for LZ4-compressed kernel Kyungsik Lee
2013-03-05 11:47 ` Kyungsik Lee
2013-03-05 11:47 ` [PATCH v3 -next 3/5] arm: " Kyungsik Lee
2013-03-05 11:47 ` Kyungsik Lee
2013-04-30 20:56 ` Andrew Morton
2013-04-30 20:56 ` Andrew Morton
2013-05-03 9:02 ` Kyungsik Lee
2013-05-03 9:02 ` Kyungsik Lee
2013-03-05 11:47 ` [PATCH v3 -next 4/5] x86: " Kyungsik Lee
2013-03-05 11:47 ` Kyungsik Lee
2013-03-05 16:13 ` H. Peter Anvin
2013-03-05 16:13 ` H. Peter Anvin
2013-03-06 6:37 ` Kyungsik Lee
2013-03-06 6:37 ` Kyungsik Lee
2013-04-25 22:43 ` Andrew Morton
2013-04-25 22:43 ` Andrew Morton
2013-03-05 11:47 ` [PATCH v3 -next 5/5] Kconfig: Make x86 and arm kernels default to the LZ4-compressed Kyungsik Lee
2013-03-05 11:47 ` Kyungsik Lee
2013-03-05 11:58 ` Borislav Petkov
2013-03-05 11:58 ` Borislav Petkov
2013-03-05 12:04 ` Florian Fainelli
2013-03-05 12:04 ` Florian Fainelli
2013-03-05 23:08 ` Andrew Morton
2013-03-05 23:08 ` Andrew Morton
2013-03-06 9:57 ` Florian Fainelli [this message]
2013-03-06 9:57 ` Florian Fainelli
2013-03-06 11:16 ` Borislav Petkov
2013-03-06 11:16 ` Borislav Petkov
2013-03-05 16:13 ` H. Peter Anvin
2013-03-05 16:13 ` H. Peter Anvin
2013-03-05 23:06 ` [PATCH v3 -next 0/5] Add support for LZ4-compressed kernel Andrew Morton
2013-03-05 23:06 ` Andrew Morton
2013-03-06 6:15 ` Kyungsik Lee
2013-03-06 6:15 ` Kyungsik Lee
2013-03-08 6:39 ` Kyungsik Lee
2013-03-08 6:39 ` Kyungsik Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51371320.6000002@openwrt.org \
--to=florian@openwrt.org \
--cc=akpm@linux-foundation.org \
--cc=celinux-dev@lists.celinuxforum.org \
--cc=chan.jeong@lge.com \
--cc=dsterba@suse.cz \
--cc=hpa@zytor.com \
--cc=hyojun.im@lge.com \
--cc=jmillenbach@gmail.com \
--cc=kyungsik.lee@lge.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mmarek@suse.cz \
--cc=nico@fluxnic.net \
--cc=nitingupta910@gmail.com \
--cc=raphael.andy.lee@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.