All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
To: Seth Forshee <seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: Matt Fleming
	<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Matthew Garrett
	<matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] efivars: Allow disabling use as a pstore backend
Date: Thu, 07 Mar 2013 12:38:49 -0800	[thread overview]
Message-ID: <5138FAD9.7050504@zytor.com> (raw)
In-Reply-To: <1362678017-2862-1-git-send-email-seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>

On 03/07/2013 09:40 AM, Seth Forshee wrote:
> We know that with some firmware implementations writing too much data to
> UEFI variables can lead to bricking machines. Recent changes attempt to
> address this issue, but for some it may still be prudent to avoid
> writing large amounts of data until the solution has been proven on a
> wide variety of hardware.
> 
> Crash dumps or other data from pstore can potentially be a large data
> source. Add a new option, CONFIG_EFI_VARS_PSTORE, which can be set to N
> to avoid using efivars as a backend to pstore.

What about a command line option?

> -#ifdef CONFIG_PSTORE
> +#if defined(CONFIG_PSTORE) && defined(CONFIG_EFI_VARS_PSTORE)

Redundant.

	-hpa

WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Matt Fleming <matt.fleming@intel.com>,
	Matthew Garrett <matthew.garrett@nebula.com>,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH] efivars: Allow disabling use as a pstore backend
Date: Thu, 07 Mar 2013 12:38:49 -0800	[thread overview]
Message-ID: <5138FAD9.7050504@zytor.com> (raw)
In-Reply-To: <1362678017-2862-1-git-send-email-seth.forshee@canonical.com>

On 03/07/2013 09:40 AM, Seth Forshee wrote:
> We know that with some firmware implementations writing too much data to
> UEFI variables can lead to bricking machines. Recent changes attempt to
> address this issue, but for some it may still be prudent to avoid
> writing large amounts of data until the solution has been proven on a
> wide variety of hardware.
> 
> Crash dumps or other data from pstore can potentially be a large data
> source. Add a new option, CONFIG_EFI_VARS_PSTORE, which can be set to N
> to avoid using efivars as a backend to pstore.

What about a command line option?

> -#ifdef CONFIG_PSTORE
> +#if defined(CONFIG_PSTORE) && defined(CONFIG_EFI_VARS_PSTORE)

Redundant.

	-hpa


  parent reply	other threads:[~2013-03-07 20:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 17:40 [PATCH] efivars: Allow disabling use as a pstore backend Seth Forshee
2013-03-07 17:40 ` Seth Forshee
     [not found] ` <1362678017-2862-1-git-send-email-seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2013-03-07 20:38   ` H. Peter Anvin [this message]
2013-03-07 20:38     ` H. Peter Anvin
     [not found]     ` <5138FAD9.7050504-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-03-07 20:59       ` Seth Forshee
2013-03-07 20:59         ` Seth Forshee
2013-03-07 22:15         ` Matt Fleming
     [not found]           ` <1362694529.15011.211.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-07 22:17             ` H. Peter Anvin
2013-03-07 22:17               ` H. Peter Anvin
2013-03-11 21:17               ` Seth Forshee
2013-03-12 19:54                 ` Matt Fleming
2013-03-12 19:54                   ` Matt Fleming
     [not found]                   ` <1363118073.15011.275.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-12 21:14                     ` Seth Forshee
2013-03-12 21:14                       ` Seth Forshee
2013-03-13 15:49                       ` Matt Fleming
     [not found]                         ` <1363189770.15011.300.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-13 17:07                           ` Seth Forshee
2013-03-13 17:07                             ` Seth Forshee
2013-03-13 17:25                             ` H. Peter Anvin
2013-03-13 17:25                               ` H. Peter Anvin
2013-03-13 18:33                               ` Matt Fleming
     [not found]                                 ` <1363199617.15011.310.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-13 19:14                                   ` Seth Forshee
2013-03-13 19:14                                     ` Seth Forshee
2013-03-13 19:44                                     ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5138FAD9.7050504@zytor.com \
    --to=hpa-ymnouzjc4hwavxtiumwx3w@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org \
    --cc=seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.