From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Marcus Granado <Marcus.Granado@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/xenconsoled: Initialise static data before use
Date: Fri, 8 Mar 2013 11:27:16 +0000 [thread overview]
Message-ID: <5139CB14.1090807@citrix.com> (raw)
In-Reply-To: <20792.58265.365439.671985@mariner.uk.xensource.com>
On 07/03/13 18:59, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH] tools/xenconsoled: Initialise static data before use"):
>> 'fds' and 'current_array_size' are used in a memset() in reset_fds(), and for
>> the first call to set_fds() before being initialised.
>>
>> Also initialise nr_fds for sanity sake.
> These variables have static storage duration and are therefore
> initialised to 0.
>
> Ian.
D'oh - I was not completely sure about this, double checked online and
managed to come up with the wrong answer.
My apologies.
The more concerning point is now "why does this appear to make a
difference" I shall continue debugging.
~Andrew
prev parent reply other threads:[~2013-03-08 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 18:45 [PATCH] tools/xenconsoled: Initialise static data before use Andrew Cooper
2013-03-07 18:54 ` Andrew Cooper
2013-03-07 20:37 ` Wei Liu
2013-03-07 18:59 ` Ian Jackson
2013-03-08 11:27 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5139CB14.1090807@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Marcus.Granado@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.