From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org,
broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: slink-tegra20: move runtime pm calls to transfer_one_message
Date: Fri, 08 Mar 2013 10:05:28 -0700 [thread overview]
Message-ID: <513A1A58.9060102@wwwdotorg.org> (raw)
In-Reply-To: <1362723679-1155-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 03/07/2013 11:21 PM, Laxman Dewangan wrote:
> The prepare_transfer_hardware() is called in atomic context and
> calling synchronous runtime pm calls can create scheduling deadlock.
>
> Therefore, in place of calling runtime PM calls from prepare/unprepare
> message transfer, calling this in transfer_one_message().
Tested-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
This does fix some slightly intermittent lockups/crashes for me when
erasing and re-writing the SPI flash on Cardhu.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: grant.likely@secretlab.ca, broonie@opensource.wolfsonmicro.com,
spi-devel-general@lists.sourceforge.net,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: slink-tegra20: move runtime pm calls to transfer_one_message
Date: Fri, 08 Mar 2013 10:05:28 -0700 [thread overview]
Message-ID: <513A1A58.9060102@wwwdotorg.org> (raw)
In-Reply-To: <1362723679-1155-1-git-send-email-ldewangan@nvidia.com>
On 03/07/2013 11:21 PM, Laxman Dewangan wrote:
> The prepare_transfer_hardware() is called in atomic context and
> calling synchronous runtime pm calls can create scheduling deadlock.
>
> Therefore, in place of calling runtime PM calls from prepare/unprepare
> message transfer, calling this in transfer_one_message().
Tested-by: Stephen Warren <swarren@nvidia.com>
This does fix some slightly intermittent lockups/crashes for me when
erasing and re-writing the SPI flash on Cardhu.
next prev parent reply other threads:[~2013-03-08 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 6:21 [PATCH] spi: slink-tegra20: move runtime pm calls to transfer_one_message Laxman Dewangan
2013-03-08 6:21 ` Laxman Dewangan
2013-03-08 6:21 ` Laxman Dewangan
[not found] ` <1362723679-1155-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-08 17:05 ` Stephen Warren [this message]
2013-03-08 17:05 ` Stephen Warren
2013-03-12 19:07 ` Mark Brown
2013-03-12 19:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513A1A58.9060102@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.