* [PATCH] drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in EXTRA_CFLAGS
@ 2013-03-10 5:04 Chen Gang
2013-03-11 14:02 ` Rob Clark
0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2013-03-10 5:04 UTC (permalink / raw)
To: airlied, robdclark, daniel.vetter; +Cc: Vladimir Kondratiev, dri-devel
When make with EXTRA_CFLAGS=-W, it will report error.
so give a check in Makefile.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
---
drivers/gpu/drm/tilcdc/Makefile | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/Makefile b/drivers/gpu/drm/tilcdc/Makefile
index deda656..562733a 100644
--- a/drivers/gpu/drm/tilcdc/Makefile
+++ b/drivers/gpu/drm/tilcdc/Makefile
@@ -1,4 +1,7 @@
-ccflags-y := -Iinclude/drm -Werror
+ccflags-y := -Iinclude/drm
+ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
+ ccflags-y += -Werror
+endif
tilcdc-y := \
tilcdc_crtc.o \
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in EXTRA_CFLAGS
2013-03-10 5:04 [PATCH] drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in EXTRA_CFLAGS Chen Gang
@ 2013-03-11 14:02 ` Rob Clark
2013-03-12 0:04 ` Chen Gang
0 siblings, 1 reply; 3+ messages in thread
From: Rob Clark @ 2013-03-11 14:02 UTC (permalink / raw)
To: Chen Gang; +Cc: daniel.vetter, dri-devel, Vladimir Kondratiev
On Sun, Mar 10, 2013 at 12:04 AM, Chen Gang <gang.chen@asianux.com> wrote:
>
> When make with EXTRA_CFLAGS=-W, it will report error.
> so give a check in Makefile.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
> drivers/gpu/drm/tilcdc/Makefile | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/Makefile b/drivers/gpu/drm/tilcdc/Makefile
> index deda656..562733a 100644
> --- a/drivers/gpu/drm/tilcdc/Makefile
> +++ b/drivers/gpu/drm/tilcdc/Makefile
> @@ -1,4 +1,7 @@
> -ccflags-y := -Iinclude/drm -Werror
> +ccflags-y := -Iinclude/drm
> +ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
> + ccflags-y += -Werror
> +endif
>
> tilcdc-y := \
> tilcdc_crtc.o \
> --
> 1.7.7.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in EXTRA_CFLAGS
2013-03-11 14:02 ` Rob Clark
@ 2013-03-12 0:04 ` Chen Gang
0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang @ 2013-03-12 0:04 UTC (permalink / raw)
To: Rob Clark; +Cc: daniel.vetter, dri-devel, Vladimir Kondratiev
于 2013年03月11日 22:02, Rob Clark 写道:
> On Sun, Mar 10, 2013 at 12:04 AM, Chen Gang <gang.chen@asianux.com> wrote:
>> >
>> > When make with EXTRA_CFLAGS=-W, it will report error.
>> > so give a check in Makefile.
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
>
thanks.
--
Chen Gang
Asianux Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-12 0:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 5:04 [PATCH] drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in EXTRA_CFLAGS Chen Gang
2013-03-11 14:02 ` Rob Clark
2013-03-12 0:04 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.