From: Gerhard Wiesinger <lists@wiesinger.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Compile error on FC17
Date: Sun, 10 Mar 2013 20:36:32 +0100 [thread overview]
Message-ID: <513CE0C0.9060104@wiesinger.com> (raw)
In-Reply-To: <CAFEAcA-J9eUVap=GJnAOiPAb=sw1AVWxiNXE2WjnHg_ANF3n_w@mail.gmail.com>
On 10.03.2013 18:04, Peter Maydell wrote:
> Oh, right. Tracing functions moved from trace.h to the files in the
> trace/ subdirectory. This means that if you didn't do a make clean or
> distclean before doing the git update then the new makefile knows
> nothing about the old trace.h file and so won't delete it, but the
> compiler may still pull it in anyhow. However this happened a long
> time back which is why I didn't mention it as a possibility (it was
> discussed on the list at the time as a number of people including me
> ran into it). If you remove all the files: trace.c trace.h
> trace.c-timestamp trace.h-timestamp this should resolve the problem.
> This is an example of a longstanding problem we have, where the
> makefile's dependency rules aren't able to cope with changes to the
> project source file structure, and so clean, distclean and incremental
> build sometimes breaks across a git update. I think this is pretty
> intractable as a problem to solve; you can mitigate it by doing all
> your builds in a build directory rather than in the source tree
> itself, since then you can always just delete the whole build tree to
> get a definite from-scratch build.
rm -f trace.c trace.h libcacard/trace.c
find . -name \*-timestamp -exec rm -f {} \;
make distclean
make clean
./configure --target-list=x86_64-softmmu
# No files found
find . -name \*-timestamp
# No files found
find . -name trace.c
# Under git version control:
# ./include/trace.h
find . -name trace.h
=> Worked well
But shouldn't "make distclean" do the job correctly (even with a changed
directory structure, at least for some time)?
Ciao,
Gerhard
next prev parent reply other threads:[~2013-03-10 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 12:28 [Qemu-devel] Compile error on FC17 Gerhard Wiesinger
2013-03-10 13:20 ` Peter Maydell
2013-03-10 15:15 ` Gerhard Wiesinger
2013-03-10 17:04 ` Peter Maydell
2013-03-10 18:52 ` Laszlo Ersek
2013-03-10 19:36 ` Gerhard Wiesinger [this message]
2013-03-10 19:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513CE0C0.9060104@wiesinger.com \
--to=lists@wiesinger.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.