All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: "Bedia, Vaibhav" <vaibhav.bedia@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"broonie@opensource.wolfsonmicro.com"
	<broonie@opensource.wolfsonmicro.com>,
	Michal Bachraty <michal.bachraty@streamunlimited.com>
Subject: Re: [PATCH] ALSA: ASoC: davinci-mcasp: clean ip davinci_hw_common_param()
Date: Mon, 11 Mar 2013 09:49:27 +0100	[thread overview]
Message-ID: <513D9A97.7030901@gmail.com> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D121433ED402CB@DBDE01.ent.ti.com>

On 11.03.2013 08:09, Bedia, Vaibhav wrote:
> On Fri, Mar 08, 2013 at 18:49:38, Daniel Mack wrote:
>> As pointed of by Vaibhav, commit 2952b27e2 ("ASoC: davinci-mcasp:
>> Add support for multichannel playback") duplicated the logic of
>> counting the active serializers. That can be avoided by shifting
>> the code around a bit.
>>
>> Also, drop two unused defines introduced by the same commit.
>>
> 
> s/clean ip/clean up/ in the $subject.
>
> Other than that, this looks fine to me.
> 
> Acked-by: Vaibhav Bedia <vaibhav.bedia@ti.com>
>

Thanks! Mark - you want me to resend with the fixed subject line or can
you do it when commiting?


Daniel

  reply	other threads:[~2013-03-11  8:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 13:19 [PATCH] ALSA: ASoC: davinci-mcasp: clean ip davinci_hw_common_param() Daniel Mack
2013-03-08 15:17 ` Michal Bachraty
2013-03-11  7:09 ` Bedia, Vaibhav
2013-03-11  8:49   ` Daniel Mack [this message]
2013-03-12 19:04 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513D9A97.7030901@gmail.com \
    --to=zonque@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=michal.bachraty@streamunlimited.com \
    --cc=vaibhav.bedia@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.