* Send to stable for "ALSA: hda - Move one-time init codes from generic_hdmi_init()"?
@ 2013-03-11 10:03 David Henningsson
2013-03-11 10:08 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: David Henningsson @ 2013-03-11 10:03 UTC (permalink / raw)
To: Takashi Iwai, alsa-devel@alsa-project.org
Hi Takashi,
Should this patch be sent to stable?
commit 8b8d654b55648561287bd8baca0f75f964a17038
Author: Takashi Iwai <tiwai@suse.de>
Date: Wed Jun 20 16:32:22 2012 +0200
ALSA: hda - Move one-time init codes from generic_hdmi_init()
I'm investigating a kernel panic under kernel 3.5, and I'm not 100% sure
(still waiting for person with hw to report back), but the only
reasonable explanation I can find is that there is some power management
activity going while the repoll timer (for hdmi_present_sense) is
running, and that generic_hdmi_init reinitializes the delayed_work
struct, thus causing the panic when the timer has elapsed.
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Send to stable for "ALSA: hda - Move one-time init codes from generic_hdmi_init()"?
2013-03-11 10:03 Send to stable for "ALSA: hda - Move one-time init codes from generic_hdmi_init()"? David Henningsson
@ 2013-03-11 10:08 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2013-03-11 10:08 UTC (permalink / raw)
To: David Henningsson; +Cc: alsa-devel@alsa-project.org
At Mon, 11 Mar 2013 11:03:09 +0100,
David Henningsson wrote:
>
> Hi Takashi,
>
> Should this patch be sent to stable?
>
> commit 8b8d654b55648561287bd8baca0f75f964a17038
> Author: Takashi Iwai <tiwai@suse.de>
> Date: Wed Jun 20 16:32:22 2012 +0200
>
> ALSA: hda - Move one-time init codes from generic_hdmi_init()
>
> I'm investigating a kernel panic under kernel 3.5, and I'm not 100% sure
> (still waiting for person with hw to report back), but the only
> reasonable explanation I can find is that there is some power management
> activity going while the repoll timer (for hdmi_present_sense) is
> running, and that generic_hdmi_init reinitializes the delayed_work
> struct, thus causing the panic when the timer has elapsed.
If the patch really fixes the issue, then yes, it's worth to send for
3.5 or earlier (if applied cleanly). In that case, better to put more
notes about the actual bug you hit (and fixed).
thanks,
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-11 10:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-11 10:03 Send to stable for "ALSA: hda - Move one-time init codes from generic_hdmi_init()"? David Henningsson
2013-03-11 10:08 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.