From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP: zoom: Use pwm stack for lcd and keyboard backlight
Date: Mon, 11 Mar 2013 14:12:03 +0200 [thread overview]
Message-ID: <513DCA13.40705@ti.com> (raw)
In-Reply-To: <1363003076-17360-1-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On 2013-03-11 13:57, Peter Ujfalusi wrote:
> Use pwm_leds driver for the keyboard light and pwm-backlight for the lcd
> backlight control (instead of implementing the PWM driver part in the board
> file).
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/mach-omap2/board-zoom-display.c | 56 ----------------------------
> arch/arm/mach-omap2/board-zoom-peripherals.c | 53 +++++++++++++++++++++++++-
> 2 files changed, 52 insertions(+), 57 deletions(-)
I can't test this, but looks fine to me. Good to get rid of the hacky
backlight code in board-zoom-display.c.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: zoom: Use pwm stack for lcd and keyboard backlight
Date: Mon, 11 Mar 2013 14:12:03 +0200 [thread overview]
Message-ID: <513DCA13.40705@ti.com> (raw)
In-Reply-To: <1363003076-17360-1-git-send-email-peter.ujfalusi@ti.com>
On 2013-03-11 13:57, Peter Ujfalusi wrote:
> Use pwm_leds driver for the keyboard light and pwm-backlight for the lcd
> backlight control (instead of implementing the PWM driver part in the board
> file).
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/mach-omap2/board-zoom-display.c | 56 ----------------------------
> arch/arm/mach-omap2/board-zoom-peripherals.c | 53 +++++++++++++++++++++++++-
> 2 files changed, 52 insertions(+), 57 deletions(-)
I can't test this, but looks fine to me. Good to get rid of the hacky
backlight code in board-zoom-display.c.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130311/c49d2c3d/attachment.sig>
next prev parent reply other threads:[~2013-03-11 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 11:57 [PATCH] ARM: OMAP: zoom: Use pwm stack for lcd and keyboard backlight Peter Ujfalusi
2013-03-11 11:57 ` Peter Ujfalusi
2013-03-11 12:12 ` Tomi Valkeinen [this message]
2013-03-11 12:12 ` Tomi Valkeinen
2013-04-08 21:46 ` Tony Lindgren
2013-04-08 21:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513DCA13.40705@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.