Re: [PATCH 04/13] dundee: Initial GDBusClient for BlueZ 5

[Daniel Wagner <wagi@monom.org>]

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

Hi Paulo,

On 03/04/2013 08:33 PM, Paulo Borges wrote:
> This patch adds the callbacks to track additions and removals of
> BlueZ related interfaces and property changes in these interfaces.
> ---
>   dundee/bluez5.c |   60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   dundee/dundee.h |    2 ++
>   2 files changed, 62 insertions(+)
>
> diff --git a/dundee/bluez5.c b/dundee/bluez5.c
> index 6685b4c..40df700 100644
> --- a/dundee/bluez5.c
> +++ b/dundee/bluez5.c
> @@ -22,16 +22,76 @@
>   #include <config.h>
>   #endif
>
> +#include <stdint.h>
> +#include <sys/socket.h>
> +#include <gdbus.h>
> +
>   #include "dundee.h"
> +#include "plugins/bluez5.h"
> +
> +#define DUN_DT_PROFILE_PATH   "/bluetooth/profile/dun_dt"
> +
> +static GDBusClient *bluez;
> +
> +static void proxy_added(GDBusProxy *proxy, void *user_data)
> +{
> +	const char *path = g_dbus_proxy_get_path(proxy);
> +	const char *interface = g_dbus_proxy_get_interface(proxy);
> +
> +	if (g_str_equal(BLUEZ_DEVICE_INTERFACE, interface) == FALSE)
> +		return;

In oFono, just use let the '== FALSE' part away. The same applies for 
the rest of the series.


cheers,
daniel