All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: ofono@ofono.org
Subject: Re: [PATCH v2 11/13] dundee: Add support for driver connect
Date: Mon, 18 Mar 2013 09:38:47 +0100	[thread overview]
Message-ID: <5146D297.6020207@monom.org> (raw)
In-Reply-To: <1363267974-13518-12-git-send-email-paulo.borges@openbossa.org>

[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]

Hi Paulo,

The series breaks to compile at this patch.

On 03/14/2013 02:32 PM, Paulo Borges wrote:
> This patch glues together the dundee driver interface with the
> D-Bus Profile1 interface.
> 
> When the dundee driver requests a connection, it will call the
> Device1's ConnectProfile.
> ---
>   dundee/bluez5.c |    7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/dundee/bluez5.c b/dundee/bluez5.c
> index 82bb7aa..2d10e5a 100644
> --- a/dundee/bluez5.c
> +++ b/dundee/bluez5.c
> @@ -114,7 +114,12 @@ static void bluetooth_device_destroy(gpointer user_data)
>   static void bluetooth_device_connect(struct dundee_device *device,
>   			dundee_device_connect_cb_t cb, void *data)
>   {
> -	DBG("");
> +	struct bluetooth_device *bt_device = dundee_device_get_data(device);
> +
> +	DBG("%s", bt_device->path);
> +
> +	bt_connect_profile(ofono_dbus_get_connection(), bt_device->path,
> +						DUN_DT_UUID, NULL, NULL);
>   }
>   
>   static void bluetooth_device_disconnect(struct dundee_device *device,
> 

HEAD is now at 1198ace dundee: Add support for driver connect
make --no-print-directory all-am
  CC       dundee/bluez5.o
dundee/bluez5.c: In function ‘bluetooth_device_connect’:
dundee/bluez5.c:122:7: error: ‘DUN_DT_UUID’ undeclared (first use in this function)
dundee/bluez5.c:122:7: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [dundee/bluez5.o] Error 1
make: *** [all] Error 2
Broke on 1198aceb147e2839a86b5f5c1cf65556d3d8fa2d


Should that be DUN_UUID?


cheers,
daniel

  reply	other threads:[~2013-03-18  8:38 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 19:33 [PATCH 00/13] Add support for BlueZ 5 Profile1 API to dundee Paulo Borges
2013-03-04 19:33 ` [PATCH 01/13] dundee: Rename dundee BlueZ 4 support Paulo Borges
2013-03-04 19:33 ` [PATCH 02/13] dundee: Start BlueZ 5 support Paulo Borges
2013-03-11 17:01   ` Daniel Wagner
2013-03-04 19:33 ` [PATCH 03/13] bluez5: Add DUN_UUID Paulo Borges
2013-03-04 19:33 ` [PATCH 04/13] dundee: Initial GDBusClient for BlueZ 5 Paulo Borges
2013-03-11 17:08   ` Daniel Wagner
2013-03-04 19:33 ` [PATCH 05/13] dundee: Add mechanism to store bluetooth devices Paulo Borges
2013-03-04 19:33 ` [PATCH 06/13] dundee: Add tracking of " Paulo Borges
2013-03-04 19:33 ` [PATCH 07/13] dundee: Listen to devices property changes Paulo Borges
2013-03-11 17:17   ` Daniel Wagner
2013-03-12  9:56     ` Daniel Wagner
2013-03-04 19:33 ` [PATCH 08/13] dundee: Add dundee device driver skeleton Paulo Borges
2013-03-04 19:33 ` [PATCH 09/13] dundee: Register/unregister dundee device Paulo Borges
2013-03-04 19:37 ` [PATCH 10/13] dundee: Add BlueZ Profile handler Paulo Borges
2013-03-04 19:38 ` [PATCH 11/13] dundee: Add support for driver connect Paulo Borges
2013-03-04 19:38 ` [PATCH 12/13] dundee: Add dundee disconnect function Paulo Borges
2013-03-04 19:39 ` [PATCH 13/13] dundee: Handle Profile connect and disconnect Paulo Borges
2013-03-11 17:23 ` [PATCH 00/13] Add support for BlueZ 5 Profile1 API to dundee Daniel Wagner
2013-03-11 20:41   ` Paulo Borges
2013-03-14 13:32 ` [PATCH v2 " Paulo Borges
2013-03-14 13:32   ` [PATCH v2 01/13] dundee: Rename dundee BlueZ 4 support Paulo Borges
2013-03-14 13:32   ` [PATCH v2 02/13] dundee: Start BlueZ 5 support Paulo Borges
2013-03-14 13:32   ` [PATCH v2 03/13] bluez5: Add DUN_UUID Paulo Borges
2013-03-14 13:32   ` [PATCH v2 04/13] dundee: Initial GDBusClient for BlueZ 5 Paulo Borges
2013-03-14 13:32   ` [PATCH v2 05/13] dundee: Add mechanism to store bluetooth devices Paulo Borges
2013-03-14 13:32   ` [PATCH v2 06/13] dundee: Add tracking of " Paulo Borges
2013-03-14 13:32   ` [PATCH v2 07/13] dundee: Listen to devices property changes Paulo Borges
2013-03-19 21:10     ` Daniel Wagner
2013-03-14 13:32   ` [PATCH v2 08/13] dundee: Add dundee device driver skeleton Paulo Borges
2013-03-14 13:32   ` [PATCH v2 09/13] dundee: Register/unregister dundee device Paulo Borges
2013-03-14 13:32   ` [PATCH v2 10/13] dundee: Add BlueZ Profile handler Paulo Borges
2013-03-14 13:32   ` [PATCH v2 11/13] dundee: Add support for driver connect Paulo Borges
2013-03-18  8:38     ` Daniel Wagner [this message]
2013-03-14 13:32   ` [PATCH v2 12/13] dundee: Add dundee disconnect function Paulo Borges
2013-03-14 13:32   ` [PATCH v2 13/13] dundee: Handle Profile connect and disconnect Paulo Borges
2013-03-18  9:55   ` [PATCH v2 00/13] Add support for BlueZ 5 Profile1 API to dundee Daniel Wagner
2013-03-19 17:11     ` Vinicius Costa Gomes
2013-03-20 22:26 ` [PATCH v3 " Paulo Borges
2013-03-20 22:26   ` [PATCH v3 01/13] dundee: Rename dundee BlueZ 4 support Paulo Borges
2013-03-20 22:26   ` [PATCH v3 02/13] dundee: Start BlueZ 5 support Paulo Borges
2013-03-20 22:26   ` [PATCH v3 03/13] bluez5: Add DUN_UUID Paulo Borges
2013-03-20 22:26   ` [PATCH v3 04/13] dundee: Initial GDBusClient for BlueZ 5 Paulo Borges
2013-03-20 22:26   ` [PATCH v3 05/13] dundee: Add mechanism to store bluetooth devices Paulo Borges
2013-03-20 22:26   ` [PATCH v3 06/13] dundee: Add tracking of " Paulo Borges
2013-03-20 22:26   ` [PATCH v3 07/13] dundee: Listen to devices property changes Paulo Borges
2013-03-20 22:26   ` [PATCH v3 08/13] dundee: Add dundee device driver skeleton Paulo Borges
2013-03-20 22:26   ` [PATCH v3 09/13] dundee: Register/unregister dundee device Paulo Borges
2013-03-20 22:26   ` [PATCH v3 10/13] dundee: Add BlueZ Profile handler Paulo Borges
2013-03-20 22:26   ` [PATCH v3 11/13] dundee: Add support for driver connect Paulo Borges
2013-03-20 22:26   ` [PATCH v3 12/13] dundee: Add dundee disconnect function Paulo Borges
2013-03-20 22:26   ` [PATCH v3 13/13] dundee: Handle Profile connect and disconnect Paulo Borges
2013-03-24 12:31   ` [PATCH v3 00/13] Add support for BlueZ 5 Profile1 API to dundee Daniel Wagner
2013-03-25 14:43     ` Paulo Borges
2013-04-02 13:12       ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5146D297.6020207@monom.org \
    --to=wagi@monom.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.