Re: [PATCH] ipr: fix addition of abort command to HRRQ free queue

Re: [PATCH] ipr: fix addition of abort command to HRRQ free queue

[Kleber Sacilotto de Souza]

Please ignore this one. Messed up with send-email --annotate.


Thanks,
Kleber

On 03/11/2013 04:33 PM, Kleber Sacilotto de Souza wrote:
> Brian/Wendy,
> 
> This is a patch for bug #89324. We were not using the right HRRQ pointer,
> so we were adding the command to the wrong free queue, which can be
> not initialized and cause a null-pointer dereference when calling
> list_add_tail().
> 
> Kleber
> 
> ---
> The abort command issued by ipr_cancel_op() is being added to the wrong
> HRRQ free queue after the command returns. Fix it by using the HRRQ
> pointer in the ipr command struct itself.
> 
> Signed-off-by: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
> ---
>  drivers/scsi/ipr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
> index f328089..b222dae 100644
> --- a/drivers/scsi/ipr.c
> +++ b/drivers/scsi/ipr.c
> @@ -5148,7 +5148,7 @@ static int ipr_cancel_op(struct scsi_cmnd *scsi_cmd)
>  		ipr_trace;
>  	}
> 
> -	list_add_tail(&ipr_cmd->queue, &hrrq->hrrq_free_q);
> +	list_add_tail(&ipr_cmd->queue, &ipr_cmd->hrrq->hrrq_free_q);
>  	if (!ipr_is_naca_model(res))
>  		res->needs_sync_complete = 1;
> 


-- 
Kleber Sacilotto de Souza
IBM Linux Technology Center