From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Timo Juhani Lindfors <timo.lindfors@iki.fi>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Pavel Emelyanov <xemul@parallels.com>,
Jiri Kosina <jkosina@suse.cz>,
Nadia Yvette Chambers <nyc@holomorphy.com>,
yrl.pp-manager.tt@hitachi.com,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH -tip ] [BUGFIX] kprobes: Move hash_64() into .text.kprobe section
Date: Tue, 12 Mar 2013 20:07:32 +0900 [thread overview]
Message-ID: <513F0C74.4030101@hitachi.com> (raw)
In-Reply-To: <20130312082112.GB30665@gmail.com>
(2013/03/12 17:21), Ingo Molnar wrote:
>
> * Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>> @@ -31,7 +32,7 @@
>> #error Wordsize not 32 or 64
>> #endif
>>
>> -static inline u64 hash_64(u64 val, unsigned int bits)
>> +static __kprobes inline u64 hash_64(u64 val, unsigned int bits)
>> {
>> u64 hash = val;
>
> We should also, really, really fix the '__kprobes' misnomer and switch to
> the '__noprobe' pattern or so. The naming does not make it obvious at all
> that what we do here is to turn _off_ kprobing of select functions...
Agreed.
> The only complication is that __kprobes is now present in 600+ places,
> which will create merge conflicts. If you remind me during the next merge
> window I can generate the rename on the spot and send it to Linus without
> anyone having to carry the patch for too long.
Let me confirm that I just move __kprobes definition into
compiler.h this time, and ping you when the next merge
window opens, is that correct?
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2013-03-12 11:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 14:22 [PATCH -tip ] [BUGFIX] kprobes: Move hash_64() into .text.kprobe section Masami Hiramatsu
2013-03-12 4:35 ` Ananth N Mavinakayanahalli
2013-03-12 8:16 ` Ingo Molnar
2013-03-12 11:03 ` Masami Hiramatsu
2013-03-12 8:21 ` Ingo Molnar
2013-03-12 11:07 ` Masami Hiramatsu [this message]
2013-03-12 12:09 ` Ingo Molnar
2013-03-12 16:04 ` Linus Torvalds
2013-03-13 6:58 ` Masami Hiramatsu
2013-03-13 13:28 ` Timo Juhani Lindfors
2013-03-13 13:46 ` Masami Hiramatsu
2013-03-18 20:57 ` Timo Juhani Lindfors
2013-03-19 2:53 ` Masami Hiramatsu
2013-03-21 11:39 ` Ingo Molnar
2013-03-21 13:23 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F0C74.4030101@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=davem@davemloft.net \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=nyc@holomorphy.com \
--cc=timo.lindfors@iki.fi \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.