From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Timo Juhani Lindfors <timo.lindfors@iki.fi>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Pavel Emelyanov <xemul@parallels.com>,
Jiri Kosina <jkosina@suse.cz>,
Nadia Yvette Chambers <nyc@holomorphy.com>,
yrl.pp-manager.tt@hitachi.com,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH -tip ] [BUGFIX] kprobes: Move hash_64() into .text.kprobe section
Date: Wed, 13 Mar 2013 22:46:49 +0900 [thread overview]
Message-ID: <51408349.8080800@hitachi.com> (raw)
In-Reply-To: <847glb8m4i.fsf@sauna.l.org>
(2013/03/13 22:28), Timo Juhani Lindfors wrote:
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> writes:
>> OK, then I'll update it to just use __always_inline.
>
> I get a similar case of infinite recursion if I try to kprobe
> "inat_get_opcode_attribute":
Oops, right! And this is caused by below callchain
set_current_kprobes->is_IF_modifier->skip_prefixes
->inat_get_opcode_attribute
However, this looks very wired that the copied instruction
(ainsn->insn) is analyzed at every probe hit.
I think we should add a bit flag indicating IF modifier
to the ainsn.
Thank you for reporting!!
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2013-03-13 13:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 14:22 [PATCH -tip ] [BUGFIX] kprobes: Move hash_64() into .text.kprobe section Masami Hiramatsu
2013-03-12 4:35 ` Ananth N Mavinakayanahalli
2013-03-12 8:16 ` Ingo Molnar
2013-03-12 11:03 ` Masami Hiramatsu
2013-03-12 8:21 ` Ingo Molnar
2013-03-12 11:07 ` Masami Hiramatsu
2013-03-12 12:09 ` Ingo Molnar
2013-03-12 16:04 ` Linus Torvalds
2013-03-13 6:58 ` Masami Hiramatsu
2013-03-13 13:28 ` Timo Juhani Lindfors
2013-03-13 13:46 ` Masami Hiramatsu [this message]
2013-03-18 20:57 ` Timo Juhani Lindfors
2013-03-19 2:53 ` Masami Hiramatsu
2013-03-21 11:39 ` Ingo Molnar
2013-03-21 13:23 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51408349.8080800@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=ananth@in.ibm.com \
--cc=davem@davemloft.net \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nyc@holomorphy.com \
--cc=timo.lindfors@iki.fi \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.