All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Ole Tange <tange@binf.ku.dk>
Cc: xfs@oss.sgi.com
Subject: Re: xfs_repair segfaults
Date: Tue, 12 Mar 2013 09:47:51 -0500	[thread overview]
Message-ID: <513F4017.6050702@sandeen.net> (raw)
In-Reply-To: <CANU9nTkG_XrNhDjGfRBofJkz=KryDmLGGJnYsBXyH5Ng=uiRWg@mail.gmail.com>

On 3/12/13 6:37 AM, Ole Tange wrote:

> $ ~/work/xfsprogs/repair/xfs_repair -L franklin.img
> Phase 1 - find and verify superblock...
> Phase 2 - using internal log
>         - zero log...
> ALERT: The filesystem has valuable metadata changes in a log which is being
> destroyed because the -L option was used.
>         - scan filesystem freespace and inode maps...
> xfs_repair: scan.c:1080: scan_freelist: Assertion `0' failed.
> Aborted (core dumped)

Oh, man.  I need to have my hacker card revoked.  Or maybe focus
on one filesystem at a time so I don't keep doing dumb things, like
adding an unconditional ASSERT in non-"-n"-mode.  Holy cow, I don't
know what's up with me lately.  :/

Anyway, just modify these 2 lines in repair/scan.c to remove the ASSERT
around line 1080.

I'll send a proper patch as well.



diff --git a/repair/scan.c b/repair/scan.c
index 6a62dff..76bb7f1 100644
--- a/repair/scan.c
+++ b/repair/scan.c
@@ -1076,8 +1076,7 @@ scan_freelist(
 				  "freelist scan\n"), i);
 			return;
 		}
-	} else /* should have been fixed in verify_set_agf() */
-		ASSERT(0);
+	}
 
 	count = 0;
 	for (;;) {




_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-03-12 14:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28 15:22 xfs_repair segfaults Ole Tange
2013-02-28 18:48 ` Eric Sandeen
2013-03-01  9:37   ` Ole Tange
2013-03-01 16:46     ` Eric Sandeen
2013-03-04  9:00       ` Ole Tange
2013-03-04 15:20         ` Eric Sandeen
2013-03-08 10:21           ` Ole Tange
2013-03-08 20:32             ` Eric Sandeen
2013-03-12 10:41               ` Ole Tange
2013-03-12 14:40                 ` Eric Sandeen
2013-03-12 11:37             ` Ole Tange
2013-03-12 14:47               ` Eric Sandeen [this message]
2013-03-01 11:17 ` Dave Chinner
2013-03-01 12:24   ` Ole Tange
2013-03-01 20:53     ` Dave Chinner
2013-03-04  9:03       ` Ole Tange
2013-03-04 23:23         ` Dave Chinner
2013-03-08 10:09           ` Ole Tange
2013-03-01 22:14 ` Eric Sandeen
2013-03-01 22:31   ` Dave Chinner
2013-03-01 22:32     ` Eric Sandeen
2013-03-01 23:55       ` Eric Sandeen
2013-03-04 12:47       ` Ole Tange
2013-03-04 15:17         ` Eric Sandeen
2013-03-04 23:11           ` Dave Chinner
  -- strict thread matches above, loose matches on Subject: below --
2013-05-06 12:06 Xfs_repair segfaults Filippo Stenico
2013-05-06 14:34 ` Eric Sandeen
2013-05-06 15:00   ` Filippo Stenico
     [not found]     ` <CADNx=Kv0bt3fNGW8Y24GziW9MOO-+b7fBGub4AYP70b5gAegxw@mail.gmail.com>
2013-05-07 13:20       ` Eric Sandeen
2013-05-07 13:36         ` Filippo Stenico
2013-05-07 18:20           ` Filippo Stenico
2013-05-08 17:30             ` Filippo Stenico
2013-05-08 17:42               ` Filippo Stenico
2013-05-08 23:39               ` Dave Chinner
2013-05-09 15:11                 ` Filippo Stenico
2013-05-09 17:22                   ` Filippo Stenico
2013-05-09 22:39                     ` Dave Chinner
     [not found]                       ` <CADNx=KuQjMNHUk6t0+hBZ5DN6s=RXqrPEjeoSxpBta47CJoDgQ@mail.gmail.com>
2013-05-10 11:00                         ` Filippo Stenico
2013-05-09 22:37                   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513F4017.6050702@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=tange@binf.ku.dk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.