From: Jiang Liu <liuj97@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
Jiang Liu <jiang.liu@huawei.com>,
Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>,
Minchan Kim <minchan@kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>, Jianguo Wu <wujianguo@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Sam Ravnborg <sam@ravnborg.org>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy syste
Date: Wed, 13 Mar 2013 16:47:23 +0000 [thread overview]
Message-ID: <5140AD9B.1030509@gmail.com> (raw)
In-Reply-To: <20130312144215.1a92be86464bf82f81e3055e@linux-foundation.org>
On 03/13/2013 05:42 AM, Andrew Morton wrote:
> On Sun, 10 Mar 2013 16:01:08 +0800 Jiang Liu <liuj97@gmail.com> wrote:
>
>> Use helper function free_highmem_page() to free highmem pages into
>> the buddy system.
>>
>> ...
>>
>> --- a/arch/sparc/mm/init_32.c
>> +++ b/arch/sparc/mm/init_32.c
>> @@ -282,14 +282,8 @@ static void map_high_region(unsigned long start_pfn, unsigned long end_pfn)
>> printk("mapping high region %08lx - %08lx\n", start_pfn, end_pfn);
>> #endif
>>
>> - for (tmp = start_pfn; tmp < end_pfn; tmp++) {
>> - struct page *page = pfn_to_page(tmp);
>> -
>> - ClearPageReserved(page);
>> - init_page_count(page);
>> - __free_page(page);
>> - totalhigh_pages++;
>> - }
>> + for (tmp = start_pfn; tmp < end_pfn; tmp++)
>> + free_higmem_page(pfn_to_page(tmp));
>> }
>
> This code isn't inside #ifdef CONFIG_HIGHMEM, but afaict that's OK
> because CONFIG_HIGHMEM=n isn't possible on sparc32.
>
> This patch and one other mistyped "free_highmem_page". I got lazy and
> edited those patches in-place.
>
Hi Andrew,
Great thanks for fixing them!
Gerry
WARNING: multiple messages have this Message-ID (diff)
From: Jiang Liu <liuj97@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
Jiang Liu <jiang.liu@huawei.com>,
Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>,
Minchan Kim <minchan@kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>, Jianguo Wu <wujianguo@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Sam Ravnborg <sam@ravnborg.org>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy system
Date: Thu, 14 Mar 2013 00:47:23 +0800 [thread overview]
Message-ID: <5140AD9B.1030509@gmail.com> (raw)
In-Reply-To: <20130312144215.1a92be86464bf82f81e3055e@linux-foundation.org>
On 03/13/2013 05:42 AM, Andrew Morton wrote:
> On Sun, 10 Mar 2013 16:01:08 +0800 Jiang Liu <liuj97@gmail.com> wrote:
>
>> Use helper function free_highmem_page() to free highmem pages into
>> the buddy system.
>>
>> ...
>>
>> --- a/arch/sparc/mm/init_32.c
>> +++ b/arch/sparc/mm/init_32.c
>> @@ -282,14 +282,8 @@ static void map_high_region(unsigned long start_pfn, unsigned long end_pfn)
>> printk("mapping high region %08lx - %08lx\n", start_pfn, end_pfn);
>> #endif
>>
>> - for (tmp = start_pfn; tmp < end_pfn; tmp++) {
>> - struct page *page = pfn_to_page(tmp);
>> -
>> - ClearPageReserved(page);
>> - init_page_count(page);
>> - __free_page(page);
>> - totalhigh_pages++;
>> - }
>> + for (tmp = start_pfn; tmp < end_pfn; tmp++)
>> + free_higmem_page(pfn_to_page(tmp));
>> }
>
> This code isn't inside #ifdef CONFIG_HIGHMEM, but afaict that's OK
> because CONFIG_HIGHMEM=n isn't possible on sparc32.
>
> This patch and one other mistyped "free_highmem_page". I got lazy and
> edited those patches in-place.
>
Hi Andrew,
Great thanks for fixing them!
Gerry
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jiang Liu <liuj97@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
Jiang Liu <jiang.liu@huawei.com>,
Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>,
Minchan Kim <minchan@kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>, Jianguo Wu <wujianguo@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Sam Ravnborg <sam@ravnborg.org>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy system
Date: Thu, 14 Mar 2013 00:47:23 +0800 [thread overview]
Message-ID: <5140AD9B.1030509@gmail.com> (raw)
In-Reply-To: <20130312144215.1a92be86464bf82f81e3055e@linux-foundation.org>
On 03/13/2013 05:42 AM, Andrew Morton wrote:
> On Sun, 10 Mar 2013 16:01:08 +0800 Jiang Liu <liuj97@gmail.com> wrote:
>
>> Use helper function free_highmem_page() to free highmem pages into
>> the buddy system.
>>
>> ...
>>
>> --- a/arch/sparc/mm/init_32.c
>> +++ b/arch/sparc/mm/init_32.c
>> @@ -282,14 +282,8 @@ static void map_high_region(unsigned long start_pfn, unsigned long end_pfn)
>> printk("mapping high region %08lx - %08lx\n", start_pfn, end_pfn);
>> #endif
>>
>> - for (tmp = start_pfn; tmp < end_pfn; tmp++) {
>> - struct page *page = pfn_to_page(tmp);
>> -
>> - ClearPageReserved(page);
>> - init_page_count(page);
>> - __free_page(page);
>> - totalhigh_pages++;
>> - }
>> + for (tmp = start_pfn; tmp < end_pfn; tmp++)
>> + free_higmem_page(pfn_to_page(tmp));
>> }
>
> This code isn't inside #ifdef CONFIG_HIGHMEM, but afaict that's OK
> because CONFIG_HIGHMEM=n isn't possible on sparc32.
>
> This patch and one other mistyped "free_highmem_page". I got lazy and
> edited those patches in-place.
>
Hi Andrew,
Great thanks for fixing them!
Gerry
next prev parent reply other threads:[~2013-03-13 16:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 8:01 [PATCH v2, part2 00/10] simplify initialization of highmem pages Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` [PATCH v2, part2 01/10] mm: introduce free_highmem_page() helper to free highmem pages into buddy system Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 10:44 ` Pekka Enberg
2013-03-10 10:44 ` Pekka Enberg
2013-03-10 8:01 ` [PATCH v2, part2 02/10] mm/ARM: use free_highmem_page() " Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` [PATCH v2, part2 03/10] mm/FRV: " Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` [PATCH v2, part2 04/10] mm/metag: " Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` [PATCH v2, part2 05/10] mm/microblaze: " Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` [PATCH v2, part2 06/10] mm/MIPS: " Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` [PATCH v2, part2 07/10] mm/PPC: " Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` [PATCH v2, part2 08/10] mm/SPARC: " Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-12 21:42 ` [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy syste Andrew Morton
2013-03-12 21:42 ` [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy system Andrew Morton
2013-03-12 21:42 ` Andrew Morton
2013-03-13 6:34 ` [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy syste Sam Ravnborg
2013-03-13 6:34 ` [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy system Sam Ravnborg
2013-03-13 6:34 ` Sam Ravnborg
2013-03-13 16:47 ` Jiang Liu [this message]
2013-03-13 16:47 ` Jiang Liu
2013-03-13 16:47 ` Jiang Liu
2013-03-10 8:01 ` [PATCH v2, part2 09/10] mm/um: " Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 8:01 ` [PATCH v2, part2 10/10] mm/x86: " Jiang Liu
2013-03-10 8:01 ` Jiang Liu
2013-03-10 10:32 ` Pekka Enberg
2013-03-10 10:32 ` Pekka Enberg
2013-03-10 10:40 ` Pekka Enberg
2013-03-10 10:40 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140AD9B.1030509@gmail.com \
--to=liuj97@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jiang.liu@huawei.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=rientjes@google.com \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=wency@cn.fujitsu.com \
--cc=wujianguo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.