Re: [PATCH -next] [SCSI] csiostor: fix error return code in csio_hw_init()

[Naresh Kumar Inna <naresh@chelsio.com>]

On 3/15/2013 2:55 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/scsi/csiostor/csio_hw.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
> index a0b4c89..d10afeb 100644
> --- a/drivers/scsi/csiostor/csio_hw.c
> +++ b/drivers/scsi/csiostor/csio_hw.c
> @@ -4036,6 +4036,7 @@ csio_hw_init(struct csio_hw *hw)
>  		evt_entry = kzalloc(sizeof(struct csio_evt_msg), GFP_KERNEL);
>  		if (!evt_entry) {
>  			csio_err(hw, "Failed to initialize eventq");
> +			rv = -ENOMEM;
>  			goto err_evtq_cleanup;
>  		}
>  
> 

Acked-by: Naresh Kumar Inna <naresh@chelsio.com>

Thanks,
Naresh.