* [PATCH -next] [SCSI] csiostor: fix error return code in csio_hw_init()
@ 2013-03-15 9:25 Wei Yongjun
2013-03-15 11:32 ` Naresh Kumar Inna
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-03-15 9:25 UTC (permalink / raw)
To: JBottomley, naresh, davem, jj, arvindb; +Cc: yongjun_wei, linux-scsi
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/scsi/csiostor/csio_hw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
index a0b4c89..d10afeb 100644
--- a/drivers/scsi/csiostor/csio_hw.c
+++ b/drivers/scsi/csiostor/csio_hw.c
@@ -4036,6 +4036,7 @@ csio_hw_init(struct csio_hw *hw)
evt_entry = kzalloc(sizeof(struct csio_evt_msg), GFP_KERNEL);
if (!evt_entry) {
csio_err(hw, "Failed to initialize eventq");
+ rv = -ENOMEM;
goto err_evtq_cleanup;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] [SCSI] csiostor: fix error return code in csio_hw_init()
2013-03-15 9:25 [PATCH -next] [SCSI] csiostor: fix error return code in csio_hw_init() Wei Yongjun
@ 2013-03-15 11:32 ` Naresh Kumar Inna
0 siblings, 0 replies; 2+ messages in thread
From: Naresh Kumar Inna @ 2013-03-15 11:32 UTC (permalink / raw)
To: Wei Yongjun
Cc: JBottomley@parallels.com, davem@davemloft.net, jj@chaosbits.net,
Arvind Bhushan, yongjun_wei@trendmicro.com.cn,
linux-scsi@vger.kernel.org
On 3/15/2013 2:55 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/scsi/csiostor/csio_hw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
> index a0b4c89..d10afeb 100644
> --- a/drivers/scsi/csiostor/csio_hw.c
> +++ b/drivers/scsi/csiostor/csio_hw.c
> @@ -4036,6 +4036,7 @@ csio_hw_init(struct csio_hw *hw)
> evt_entry = kzalloc(sizeof(struct csio_evt_msg), GFP_KERNEL);
> if (!evt_entry) {
> csio_err(hw, "Failed to initialize eventq");
> + rv = -ENOMEM;
> goto err_evtq_cleanup;
> }
>
>
Acked-by: Naresh Kumar Inna <naresh@chelsio.com>
Thanks,
Naresh.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-15 11:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-15 9:25 [PATCH -next] [SCSI] csiostor: fix error return code in csio_hw_init() Wei Yongjun
2013-03-15 11:32 ` Naresh Kumar Inna
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.