All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naresh Kumar Inna <naresh@chelsio.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: "JBottomley@parallels.com" <JBottomley@parallels.com>,
	"jj@chaosbits.net" <jj@chaosbits.net>,
	Arvind Bhushan <arvindb@chelsio.com>,
	"yongjun_wei@trendmicro.com.cn" <yongjun_wei@trendmicro.com.cn>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH -next] [SCSI] csiostor: remove unused variable in csio_process_fwevtq_entry()
Date: Fri, 15 Mar 2013 17:04:27 +0530	[thread overview]
Message-ID: <51430743.1060807@chelsio.com> (raw)
In-Reply-To: <CAPgLHd-HDkjb6OPH+46KQo3fwP-_H78S+G6CcqdwgvgrXoOHkw@mail.gmail.com>

On 3/15/2013 3:31 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> The variable 'data' is initialized but never used
> otherwise, so remove the unused variable.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/scsi/csiostor/csio_hw.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
> index a0b4c89..1936055 100644
> --- a/drivers/scsi/csiostor/csio_hw.c
> +++ b/drivers/scsi/csiostor/csio_hw.c
> @@ -3565,7 +3565,6 @@ csio_process_fwevtq_entry(struct csio_hw *hw, void *wr, uint32_t len,
>  			  struct csio_fl_dma_buf *flb, void *priv)
>  {
>  	__u8 op;
> -	__be64 *data;
>  	void *msg = NULL;
>  	uint32_t msg_len = 0;
>  	bool msg_sg = 0;
> @@ -3581,8 +3580,6 @@ csio_process_fwevtq_entry(struct csio_hw *hw, void *wr, uint32_t len,
>  		msg = (void *) flb;
>  		msg_len = flb->totlen;
>  		msg_sg = 1;
> -
> -		data = (__be64 *) msg;
>  	} else if (op == CPL_FW6_MSG || op == CPL_FW4_MSG) {
>  
>  		CSIO_INC_STATS(hw, n_cpl_fw6_msg);
> @@ -3590,8 +3587,6 @@ csio_process_fwevtq_entry(struct csio_hw *hw, void *wr, uint32_t len,
>  		msg = (void *)((uintptr_t)wr + sizeof(__be64));
>  		msg_len = (op == CPL_FW6_MSG) ? sizeof(struct cpl_fw6_msg) :
>  			   sizeof(struct cpl_fw4_msg);
> -
> -		data = (__be64 *) msg;
>  	} else {
>  		csio_warn(hw, "unexpected CPL %#x on FW event queue\n", op);
>  		CSIO_INC_STATS(hw, n_cpl_unexp);
> 
> 

Acked-by: Naresh Kumar Inna <naresh@chelsio.com>

Thanks,
Naresh.

      reply	other threads:[~2013-03-15 11:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 10:01 [PATCH -next] [SCSI] csiostor: remove unused variable in csio_process_fwevtq_entry() Wei Yongjun
2013-03-15 11:34 ` Naresh Kumar Inna [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51430743.1060807@chelsio.com \
    --to=naresh@chelsio.com \
    --cc=JBottomley@parallels.com \
    --cc=arvindb@chelsio.com \
    --cc=jj@chaosbits.net \
    --cc=linux-scsi@vger.kernel.org \
    --cc=weiyj.lk@gmail.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.