* [PATCH -next] [SCSI] csiostor: remove unused variable in csio_process_fwevtq_entry()
@ 2013-03-15 10:01 Wei Yongjun
2013-03-15 11:34 ` Naresh Kumar Inna
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-03-15 10:01 UTC (permalink / raw)
To: JBottomley, naresh, jj, arvindb; +Cc: yongjun_wei, linux-scsi
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
The variable 'data' is initialized but never used
otherwise, so remove the unused variable.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/scsi/csiostor/csio_hw.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
index a0b4c89..1936055 100644
--- a/drivers/scsi/csiostor/csio_hw.c
+++ b/drivers/scsi/csiostor/csio_hw.c
@@ -3565,7 +3565,6 @@ csio_process_fwevtq_entry(struct csio_hw *hw, void *wr, uint32_t len,
struct csio_fl_dma_buf *flb, void *priv)
{
__u8 op;
- __be64 *data;
void *msg = NULL;
uint32_t msg_len = 0;
bool msg_sg = 0;
@@ -3581,8 +3580,6 @@ csio_process_fwevtq_entry(struct csio_hw *hw, void *wr, uint32_t len,
msg = (void *) flb;
msg_len = flb->totlen;
msg_sg = 1;
-
- data = (__be64 *) msg;
} else if (op == CPL_FW6_MSG || op == CPL_FW4_MSG) {
CSIO_INC_STATS(hw, n_cpl_fw6_msg);
@@ -3590,8 +3587,6 @@ csio_process_fwevtq_entry(struct csio_hw *hw, void *wr, uint32_t len,
msg = (void *)((uintptr_t)wr + sizeof(__be64));
msg_len = (op == CPL_FW6_MSG) ? sizeof(struct cpl_fw6_msg) :
sizeof(struct cpl_fw4_msg);
-
- data = (__be64 *) msg;
} else {
csio_warn(hw, "unexpected CPL %#x on FW event queue\n", op);
CSIO_INC_STATS(hw, n_cpl_unexp);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] [SCSI] csiostor: remove unused variable in csio_process_fwevtq_entry()
2013-03-15 10:01 [PATCH -next] [SCSI] csiostor: remove unused variable in csio_process_fwevtq_entry() Wei Yongjun
@ 2013-03-15 11:34 ` Naresh Kumar Inna
0 siblings, 0 replies; 2+ messages in thread
From: Naresh Kumar Inna @ 2013-03-15 11:34 UTC (permalink / raw)
To: Wei Yongjun
Cc: JBottomley@parallels.com, jj@chaosbits.net, Arvind Bhushan,
yongjun_wei@trendmicro.com.cn, linux-scsi@vger.kernel.org
On 3/15/2013 3:31 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The variable 'data' is initialized but never used
> otherwise, so remove the unused variable.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/scsi/csiostor/csio_hw.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
> index a0b4c89..1936055 100644
> --- a/drivers/scsi/csiostor/csio_hw.c
> +++ b/drivers/scsi/csiostor/csio_hw.c
> @@ -3565,7 +3565,6 @@ csio_process_fwevtq_entry(struct csio_hw *hw, void *wr, uint32_t len,
> struct csio_fl_dma_buf *flb, void *priv)
> {
> __u8 op;
> - __be64 *data;
> void *msg = NULL;
> uint32_t msg_len = 0;
> bool msg_sg = 0;
> @@ -3581,8 +3580,6 @@ csio_process_fwevtq_entry(struct csio_hw *hw, void *wr, uint32_t len,
> msg = (void *) flb;
> msg_len = flb->totlen;
> msg_sg = 1;
> -
> - data = (__be64 *) msg;
> } else if (op == CPL_FW6_MSG || op == CPL_FW4_MSG) {
>
> CSIO_INC_STATS(hw, n_cpl_fw6_msg);
> @@ -3590,8 +3587,6 @@ csio_process_fwevtq_entry(struct csio_hw *hw, void *wr, uint32_t len,
> msg = (void *)((uintptr_t)wr + sizeof(__be64));
> msg_len = (op == CPL_FW6_MSG) ? sizeof(struct cpl_fw6_msg) :
> sizeof(struct cpl_fw4_msg);
> -
> - data = (__be64 *) msg;
> } else {
> csio_warn(hw, "unexpected CPL %#x on FW event queue\n", op);
> CSIO_INC_STATS(hw, n_cpl_unexp);
>
>
Acked-by: Naresh Kumar Inna <naresh@chelsio.com>
Thanks,
Naresh.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-15 11:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-15 10:01 [PATCH -next] [SCSI] csiostor: remove unused variable in csio_process_fwevtq_entry() Wei Yongjun
2013-03-15 11:34 ` Naresh Kumar Inna
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.