From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support
Date: Fri, 15 Mar 2013 12:51:23 +0000 [thread overview]
Message-ID: <5143194B.2040600@cogentembedded.com> (raw)
In-Reply-To: <87boal32nh.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 15-03-2013 4:52, Kuninori Morimoto wrote:
>>> I forgot detail of it, but these usb is using callback function,
>>> and it is using *phy*.
>> But this PHY also belongs to SoC.
>>> This phy came from marzen_init_late() with usb_get_phy(USB_PHY_TYPE_USB2);
>>> This usb_get_phy() is not needed if board doesn't have USB.
>> Anyway, there should be ways to separate the board specific platform code
>> and the SoC specific one. That's what other subarches do.
>>> You can modify it if you want
>> Yes, I definitely would like to try.
> I checked CPG :: MSTP for USB0/1/2 and USB Host/Function,
> and GIC number for it.
> It seems no conflict each other
> I guess EHCI/OHCI goes to setup seems no problem.
> But, as you pointed on USB ML,
> USB-PHY :: USBPCTRL0 depends on platform
> (Host/Function selection, and OVC pin setting)
> rcar_usb_phy driver belongs to platform
No, it doesn't. Only it's (future) platform data will belong to the board --
that's what they were designed for.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support
Date: Fri, 15 Mar 2013 16:51:23 +0400 [thread overview]
Message-ID: <5143194B.2040600@cogentembedded.com> (raw)
In-Reply-To: <87boal32nh.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 15-03-2013 4:52, Kuninori Morimoto wrote:
>>> I forgot detail of it, but these usb is using callback function,
>>> and it is using *phy*.
>> But this PHY also belongs to SoC.
>>> This phy came from marzen_init_late() with usb_get_phy(USB_PHY_TYPE_USB2);
>>> This usb_get_phy() is not needed if board doesn't have USB.
>> Anyway, there should be ways to separate the board specific platform code
>> and the SoC specific one. That's what other subarches do.
>>> You can modify it if you want
>> Yes, I definitely would like to try.
> I checked CPG :: MSTP for USB0/1/2 and USB Host/Function,
> and GIC number for it.
> It seems no conflict each other
> I guess EHCI/OHCI goes to setup seems no problem.
> But, as you pointed on USB ML,
> USB-PHY :: USBPCTRL0 depends on platform
> (Host/Function selection, and OVC pin setting)
> rcar_usb_phy driver belongs to platform
No, it doesn't. Only it's (future) platform data will belong to the board --
that's what they were designed for.
WBR, Sergei
next prev parent reply other threads:[~2013-03-15 12:51 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 0:40 [GIT PULL v3] Renesas ARM-based SoC boards for v3.8 Simon Horman
2012-11-01 0:40 ` Simon Horman
2012-11-01 0:40 ` [PATCH 1/8] ARM: shmobile: kzm9g: enable magnetometer ak8975 Simon Horman
2012-11-01 0:40 ` Simon Horman
2012-11-01 0:40 ` [PATCH 2/8] ARM: shmobile: kzm9g: enable three-axis digital accelerometer ADXL345 Simon Horman
2012-11-01 0:40 ` Simon Horman
2012-11-01 0:40 ` [PATCH 3/8] ARM: shmobile: kzm9g: enable DMAEngine on SHDI0 and SDHI2 Simon Horman
2012-11-01 0:40 ` Simon Horman
2012-11-01 0:40 ` [PATCH 4/8] ARM: shmobile: armadillo800eva: enable restart Simon Horman
2012-11-01 0:40 ` Simon Horman
2012-11-01 0:40 ` [PATCH 5/8] ARM: shmobile: marzen: add HSPI support Simon Horman
2012-11-01 0:40 ` Simon Horman
2012-11-01 0:40 ` [PATCH 6/8] ARM: mach-shmobile: Use DT_MACHINE for mackerel Simon Horman
2012-11-01 0:40 ` Simon Horman
2012-11-01 0:40 ` [PATCH 7/8] ARM: shmobile: Remove G3EVM machine support Simon Horman
2012-11-01 0:40 ` Simon Horman
2012-11-01 0:40 ` [PATCH 8/8] ARM: shmobile: Remove G4EVM " Simon Horman
2012-11-01 0:40 ` Simon Horman
2012-11-06 2:32 ` [GIT PULL v3] Renesas ARM-based SoC boards for v3.8 Simon Horman
2012-11-06 2:32 ` Simon Horman
2012-11-06 14:07 ` Olof Johansson
2012-11-06 14:07 ` Olof Johansson
2012-11-09 7:31 ` [GIT PULL v3] Renesas ARM-based SoC boards for v3.8 #2 Simon Horman
2012-11-09 7:31 ` Simon Horman
2012-11-09 7:31 ` [PATCH 1/7] ARM: shmobile: marzen: add USB phy support Simon Horman
2012-11-09 7:31 ` Simon Horman
2013-03-13 21:19 ` Sergei Shtylyov
2013-03-13 22:20 ` Sergei Shtylyov
2013-03-14 0:44 ` Kuninori Morimoto
2013-03-14 0:44 ` Kuninori Morimoto
2013-03-14 13:20 ` Sergei Shtylyov
2013-03-14 13:20 ` Sergei Shtylyov
2012-11-09 7:31 ` [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support Simon Horman
2012-11-09 7:31 ` Simon Horman
2013-03-13 20:44 ` Sergei Shtylyov
2013-03-13 21:45 ` Sergei Shtylyov
2013-03-14 0:29 ` Kuninori Morimoto
2013-03-14 0:29 ` Kuninori Morimoto
2013-03-14 1:09 ` Kuninori Morimoto
2013-03-14 1:09 ` Kuninori Morimoto
2013-03-14 13:42 ` Sergei Shtylyov
2013-03-14 13:42 ` Sergei Shtylyov
2013-03-15 0:52 ` Kuninori Morimoto
2013-03-15 0:52 ` Kuninori Morimoto
2013-03-15 12:51 ` Sergei Shtylyov [this message]
2013-03-15 12:51 ` Sergei Shtylyov
2012-11-09 7:31 ` [PATCH 3/7] ARM: shmobile: marzen: add USB OHCI " Simon Horman
2012-11-09 7:31 ` Simon Horman
2012-11-09 7:31 ` [PATCH 4/7] ARM: shmobile: mackerel: enable DMAEngine on USB Host Simon Horman
2012-11-09 7:31 ` Simon Horman
2012-11-09 7:31 ` [PATCH 5/7] ARM: shmobile: use FSI driver's audio clock on armadillo800eva Simon Horman
2012-11-09 7:31 ` Simon Horman
2012-11-09 7:31 ` [PATCH 6/7] ARM: shmobile: use FSI driver's audio clock on mackerel Simon Horman
2012-11-09 7:31 ` Simon Horman
2012-11-09 7:31 ` [PATCH 7/7] ARM: shmobile: use FSI driver's audio clock on ap4evb Simon Horman
2012-11-09 7:31 ` Simon Horman
2012-11-12 21:11 ` [GIT PULL v3] Renesas ARM-based SoC boards for v3.8 #2 Arnd Bergmann
2012-11-12 21:11 ` Arnd Bergmann
2012-11-13 2:58 ` Simon Horman
2012-11-13 2:58 ` Simon Horman
2012-11-13 5:36 ` Mark Brown
2012-11-13 5:36 ` Mark Brown
2012-11-13 8:48 ` Arnd Bergmann
2012-11-13 8:48 ` Arnd Bergmann
2012-11-13 10:01 ` Mark Brown
2012-11-13 10:01 ` Mark Brown
2012-11-13 10:27 ` Arnd Bergmann
2012-11-13 10:27 ` Arnd Bergmann
2012-11-14 2:15 ` Mark Brown
2012-11-14 2:15 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-11-08 1:27 [GIT PULL v2] " Simon Horman
2012-11-08 1:27 ` [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support Simon Horman
2012-11-08 1:27 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5143194B.2040600@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.