* DaVinci platform unable to boot via NFS
@ 2013-03-15 13:41 ` Prabhakar Lad
0 siblings, 0 replies; 6+ messages in thread
From: Prabhakar Lad @ 2013-03-15 13:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mugunthan,
With 3.9 release I am not able to boot any davinci board via nfs, finally
digging Into I found that there were recent changes for Ethernet davinci.
Finally I reverting this to some safe commit I was able to boot via nfs.
I reverted back as following:-
git checkout f9a8f83b04e0c362a2fc660dbad980d24af209fc drivers/net/ethernet/ti/
Can you please take a look at and fix it.
Cheers,
--Prabhakar Lad
http://in.linkedin.com/pub/prabhakar-lad/19/92b/955
^ permalink raw reply [flat|nested] 6+ messages in thread
* DaVinci platform unable to boot via NFS
@ 2013-03-15 13:41 ` Prabhakar Lad
0 siblings, 0 replies; 6+ messages in thread
From: Prabhakar Lad @ 2013-03-15 13:41 UTC (permalink / raw)
To: mugunthanvnm; +Cc: netdev, dlos, Sekhar Nori, LAK
Hi Mugunthan,
With 3.9 release I am not able to boot any davinci board via nfs, finally
digging Into I found that there were recent changes for Ethernet davinci.
Finally I reverting this to some safe commit I was able to boot via nfs.
I reverted back as following:-
git checkout f9a8f83b04e0c362a2fc660dbad980d24af209fc drivers/net/ethernet/ti/
Can you please take a look at and fix it.
Cheers,
--Prabhakar Lad
http://in.linkedin.com/pub/prabhakar-lad/19/92b/955
^ permalink raw reply [flat|nested] 6+ messages in thread
* DaVinci platform unable to boot via NFS
2013-03-15 13:41 ` Prabhakar Lad
@ 2013-03-15 14:17 ` Sekhar Nori
-1 siblings, 0 replies; 6+ messages in thread
From: Sekhar Nori @ 2013-03-15 14:17 UTC (permalink / raw)
To: linux-arm-kernel
Prabhakar,
On 3/15/2013 7:11 PM, Prabhakar Lad wrote:
> Hi Mugunthan,
>
> With 3.9 release I am not able to boot any davinci board via nfs, finally
> digging Into I found that there were recent changes for Ethernet davinci.
> Finally I reverting this to some safe commit I was able to boot via nfs.
> I reverted back as following:-
> git checkout f9a8f83b04e0c362a2fc660dbad980d24af209fc drivers/net/ethernet/ti/
>
> Can you please take a look at and fix it.
>
> Cheers,
> --Prabhakar Lad
> http://in.linkedin.com/pub/prabhakar-lad/19/92b/955
>
A similar bug was reported on cpsw and the following patch from Daniel
seems to have helped.
https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=d35162f89b8f00537d7b240b76d2d0e8b8d29aa0
I made a similar fix for davinci_emac.c and the resulting diff is below
(not tested or built).
Can you please check if this helps in DaVinci case?
Thanks,
Sekhar
----8<----
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
index 52c0536..ae1b77a 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -1102,7 +1102,7 @@ static int emac_dev_xmit(struct sk_buff *skb, struct net_device *ndev)
/* If there is no more tx desc left free then we need to
* tell the kernel to stop sending us tx frames.
*/
- if (unlikely(cpdma_check_free_tx_desc(priv->txchan)))
+ if (unlikely(!cpdma_check_free_tx_desc(priv->txchan)))
netif_stop_queue(ndev);
return NETDEV_TX_OK;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: DaVinci platform unable to boot via NFS
@ 2013-03-15 14:17 ` Sekhar Nori
0 siblings, 0 replies; 6+ messages in thread
From: Sekhar Nori @ 2013-03-15 14:17 UTC (permalink / raw)
To: Prabhakar Lad; +Cc: mugunthanvnm, dlos, LAK, netdev, Daniel Mack, Mark Jackson
Prabhakar,
On 3/15/2013 7:11 PM, Prabhakar Lad wrote:
> Hi Mugunthan,
>
> With 3.9 release I am not able to boot any davinci board via nfs, finally
> digging Into I found that there were recent changes for Ethernet davinci.
> Finally I reverting this to some safe commit I was able to boot via nfs.
> I reverted back as following:-
> git checkout f9a8f83b04e0c362a2fc660dbad980d24af209fc drivers/net/ethernet/ti/
>
> Can you please take a look at and fix it.
>
> Cheers,
> --Prabhakar Lad
> http://in.linkedin.com/pub/prabhakar-lad/19/92b/955
>
A similar bug was reported on cpsw and the following patch from Daniel
seems to have helped.
https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=d35162f89b8f00537d7b240b76d2d0e8b8d29aa0
I made a similar fix for davinci_emac.c and the resulting diff is below
(not tested or built).
Can you please check if this helps in DaVinci case?
Thanks,
Sekhar
----8<----
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
index 52c0536..ae1b77a 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -1102,7 +1102,7 @@ static int emac_dev_xmit(struct sk_buff *skb, struct net_device *ndev)
/* If there is no more tx desc left free then we need to
* tell the kernel to stop sending us tx frames.
*/
- if (unlikely(cpdma_check_free_tx_desc(priv->txchan)))
+ if (unlikely(!cpdma_check_free_tx_desc(priv->txchan)))
netif_stop_queue(ndev);
return NETDEV_TX_OK;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* DaVinci platform unable to boot via NFS
2013-03-15 13:41 ` Prabhakar Lad
@ 2013-03-15 14:17 ` Mugunthan V N
-1 siblings, 0 replies; 6+ messages in thread
From: Mugunthan V N @ 2013-03-15 14:17 UTC (permalink / raw)
To: linux-arm-kernel
On 3/15/2013 7:11 PM, Prabhakar Lad wrote:
> Hi Mugunthan,
>
> With 3.9 release I am not able to boot any davinci board via nfs, finally
> digging Into I found that there were recent changes for Ethernet davinci.
> Finally I reverting this to some safe commit I was able to boot via nfs.
> I reverted back as following:-
> git checkout f9a8f83b04e0c362a2fc660dbad980d24af209fc drivers/net/ethernet/ti/
>
> Can you please take a look at and fix it.
>
> Cheers,
> --Prabhakar Lad
> http://in.linkedin.com/pub/prabhakar-lad/19/92b/955
The issue is also reported in CPSW driver and is fixed already. I have
posted the patch for Davinci EMAC in the below link.
http://patchwork.ozlabs.org/patch/228003/
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-15 14:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-15 13:41 DaVinci platform unable to boot via NFS Prabhakar Lad
2013-03-15 13:41 ` Prabhakar Lad
2013-03-15 14:17 ` Sekhar Nori
2013-03-15 14:17 ` Sekhar Nori
2013-03-15 14:17 ` Mugunthan V N
2013-03-15 14:17 ` Mugunthan V N
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.