From: Jon Hunter <jon-hunter@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap@vger.kernel.org,
"Kevin Hilman" <khilman@deeprootsystems.com>,
"Benoît Cousson" <b-cousson@ti.com>,
"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
"Shawn Guo" <shawn.guo@linaro.org>, Keerthy <j-keerthy@ti.com>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/8] ARM: dts: OMAP36xx: move CPU OPP tables to device tree
Date: Fri, 15 Mar 2013 09:26:28 -0500 [thread overview]
Message-ID: <51432F94.7000306@ti.com> (raw)
In-Reply-To: <20130315135655.GA2939@kahuna>
On 03/15/2013 08:56 AM, Nishanth Menon wrote:
> On 16:44-20130314, Jon Hunter wrote:
>>
>> On 03/14/2013 03:58 PM, Nishanth Menon wrote:
>>> Add DT OPP table for OMAP36xx family of devices. This data is
>>> decoded by OF with of_init_opp_table() helper function. This
>>> overrides the default OMAP34xx CPU OPP table definition.
>>
>> Not sure I following the last sentence. The tables are in a different
>> dtsi file and only the relevant file should be included, right?
> omap3630.dsi includes omap3.dtsi (which is meant for OMAP34xx).
> The opp tables introduced by this patch in omap36xx.dtsi will override
> the ones defined on omap3.dtsi. Will the following rephrase help clarify
> this?
>
> Original:
> This overrides the default OMAP34xx CPU OPP table definition.
> Suggested;
> This overrides the default OMAP34xx CPU OPP table definition in
> omap3.dtsi.
Sorry, I just missed that the omap3430 opps were in omap3.dtsi and not
omap34xx.dtsi. I guess I am not familiar with how the DTC overrides
nodes, however, at least from a readability standpoint it would seem
nice to have the omap3430 opps in a omap3430 specific dtsi and not
omap3.dtsi. However, thats just my opinion.
Cheers
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] ARM: dts: OMAP36xx: move CPU OPP tables to device tree
Date: Fri, 15 Mar 2013 09:26:28 -0500 [thread overview]
Message-ID: <51432F94.7000306@ti.com> (raw)
In-Reply-To: <20130315135655.GA2939@kahuna>
On 03/15/2013 08:56 AM, Nishanth Menon wrote:
> On 16:44-20130314, Jon Hunter wrote:
>>
>> On 03/14/2013 03:58 PM, Nishanth Menon wrote:
>>> Add DT OPP table for OMAP36xx family of devices. This data is
>>> decoded by OF with of_init_opp_table() helper function. This
>>> overrides the default OMAP34xx CPU OPP table definition.
>>
>> Not sure I following the last sentence. The tables are in a different
>> dtsi file and only the relevant file should be included, right?
> omap3630.dsi includes omap3.dtsi (which is meant for OMAP34xx).
> The opp tables introduced by this patch in omap36xx.dtsi will override
> the ones defined on omap3.dtsi. Will the following rephrase help clarify
> this?
>
> Original:
> This overrides the default OMAP34xx CPU OPP table definition.
> Suggested;
> This overrides the default OMAP34xx CPU OPP table definition in
> omap3.dtsi.
Sorry, I just missed that the omap3430 opps were in omap3.dtsi and not
omap34xx.dtsi. I guess I am not familiar with how the DTC overrides
nodes, however, at least from a readability standpoint it would seem
nice to have the omap3430 opps in a omap3430 specific dtsi and not
omap3.dtsi. However, thats just my opinion.
Cheers
Jon
next prev parent reply other threads:[~2013-03-15 14:26 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 20:58 [PATCH 0/8] ARM: OMAP3+: Switch to use DT based cpu0-cpufreq driver Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` [PATCH 1/8] ARM: dts: OMAP34xx: move CPU OPP tables to device tree Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 21:43 ` Jon Hunter
2013-03-14 21:43 ` Jon Hunter
2013-03-14 20:58 ` [PATCH 2/8] ARM: dts: OMAP36xx: " Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 21:44 ` Jon Hunter
2013-03-14 21:44 ` Jon Hunter
2013-03-15 13:56 ` Nishanth Menon
2013-03-15 13:56 ` Nishanth Menon
2013-03-15 14:26 ` Jon Hunter [this message]
2013-03-15 14:26 ` Jon Hunter
2013-03-15 14:38 ` Nishanth Menon
2013-03-15 14:38 ` Nishanth Menon
2013-03-15 14:58 ` Jon Hunter
2013-03-15 14:58 ` Jon Hunter
2013-03-15 15:02 ` Nishanth Menon
2013-03-15 15:02 ` Nishanth Menon
2013-03-14 20:58 ` [PATCH 3/8] ARM: dts: OMAP3: use twl4030 vdd1 regulator for CPU Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` [PATCH 4/8] ARM: dts: OMAP443x: move CPU OPP tables to device tree Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` [PATCH 5/8] ARM: dts: omap4-panda: move generic sections to panda-common Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` [PATCH 6/8] ARM: dts: OMAP446x: move CPU OPP tables to device tree Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 21:49 ` Jon Hunter
2013-03-14 21:49 ` Jon Hunter
2013-03-15 14:08 ` Nishanth Menon
2013-03-15 14:08 ` Nishanth Menon
2013-03-14 20:58 ` [PATCH 7/8] ARM: OMAP3+: use cpu0-cpufreq driver Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` [PATCH 8/8] cpufreq: omap: remove omap-cpufreq Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-14 20:58 ` Nishanth Menon
2013-03-15 4:51 ` Viresh Kumar
2013-03-15 4:51 ` Viresh Kumar
2013-03-15 14:24 ` Nishanth Menon
2013-03-15 14:24 ` Nishanth Menon
2013-03-15 14:24 ` Nishanth Menon
2013-03-14 21:42 ` [PATCH 0/8] ARM: OMAP3+: Switch to use DT based cpu0-cpufreq driver Jon Hunter
2013-03-14 21:42 ` Jon Hunter
2013-03-15 13:52 ` Nishanth Menon
2013-03-15 13:52 ` Nishanth Menon
2013-03-15 5:18 ` Santosh Shilimkar
2013-03-15 5:18 ` Santosh Shilimkar
2013-03-15 14:21 ` Nishanth Menon
2013-03-15 14:21 ` Nishanth Menon
2013-03-15 14:56 ` Jon Hunter
2013-03-15 14:56 ` Jon Hunter
2013-03-15 15:00 ` Nishanth Menon
2013-03-15 15:00 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51432F94.7000306@ti.com \
--to=jon-hunter@ti.com \
--cc=b-cousson@ti.com \
--cc=cpufreq@vger.kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=j-keerthy@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.