From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: document the "GPIO mode" pitfall
Date: Fri, 15 Mar 2013 14:53:53 -0600 [thread overview]
Message-ID: <51438A61.2050704@wwwdotorg.org> (raw)
In-Reply-To: <1363345636-2006-1-git-send-email-linus.walleij@stericsson.com>
On 03/15/2013 05:07 AM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> Recently as adoption of the pinctrl framework is reaching
> niches where the pins are reconfigured during system sleep
> and datasheets often talk about something called "GPIO mode",
> some engineers become confused by this, thinking that since
> it is named "GPIO (something something)" it must be modeled
> in the kernel using <linux/gpio.h>.
> +static struct pinctrl_map __initdata pinmap[] = {
> + PIN_MAP_MUX_GROUP("uart", PINCTRL_STATE_DEFAULT", "pinctrl-foo",
Extra trailing " after PINCTRL_STATE_DEFAULT there.
Otherwise, this sounds plausible, so,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stephen Warren <swarren@nvidia.com>,
Anmar Oueja <anmar.oueja@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Pankaj Dev <pankaj.dev@st.com>
Subject: Re: [PATCH] pinctrl: document the "GPIO mode" pitfall
Date: Fri, 15 Mar 2013 14:53:53 -0600 [thread overview]
Message-ID: <51438A61.2050704@wwwdotorg.org> (raw)
In-Reply-To: <1363345636-2006-1-git-send-email-linus.walleij@stericsson.com>
On 03/15/2013 05:07 AM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> Recently as adoption of the pinctrl framework is reaching
> niches where the pins are reconfigured during system sleep
> and datasheets often talk about something called "GPIO mode",
> some engineers become confused by this, thinking that since
> it is named "GPIO (something something)" it must be modeled
> in the kernel using <linux/gpio.h>.
> +static struct pinctrl_map __initdata pinmap[] = {
> + PIN_MAP_MUX_GROUP("uart", PINCTRL_STATE_DEFAULT", "pinctrl-foo",
Extra trailing " after PINCTRL_STATE_DEFAULT there.
Otherwise, this sounds plausible, so,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2013-03-15 20:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 11:07 [PATCH] pinctrl: document the "GPIO mode" pitfall Linus Walleij
2013-03-15 11:07 ` Linus Walleij
2013-03-15 20:53 ` Stephen Warren [this message]
2013-03-15 20:53 ` Stephen Warren
2013-04-23 13:33 ` Laurent Pinchart
2013-04-23 13:33 ` Laurent Pinchart
2013-04-25 21:39 ` Linus Walleij
2013-04-25 21:39 ` Linus Walleij
2013-04-25 23:15 ` Laurent Pinchart
2013-04-25 23:15 ` Laurent Pinchart
2013-04-26 8:49 ` Linus Walleij
2013-04-26 8:49 ` Linus Walleij
2013-04-27 1:16 ` Laurent Pinchart
2013-04-27 1:16 ` Laurent Pinchart
2013-05-12 23:36 ` Linus Walleij
2013-05-12 23:36 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51438A61.2050704@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.