From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/2] ARM: davinci: dm365: add support for v4l2 video display
Date: Mon, 18 Mar 2013 15:17:54 +0530 [thread overview]
Message-ID: <5146E2CA.8000109@ti.com> (raw)
In-Reply-To: <CA+V-a8umwxKFHjSQ=yDwfp8VWTQyn0dyp-=ESSUvRPXawt01Jg@mail.gmail.com>
On 3/18/2013 2:46 PM, Prabhakar Lad wrote:
> On Mon, Mar 18, 2013 at 1:48 PM, Sekhar Nori <nsekhar@ti.com> wrote:
>> On 3/15/2013 8:41 PM, Prabhakar lad wrote:
>>> +int __init dm365_init_video(struct vpfe_config *vpfe_cfg,
>>> + struct vpbe_config *vpbe_cfg)
>>> +{
>>> + if (vpfe_cfg || vpbe_cfg)
>>> + platform_device_register(&dm365_vpss_device);
>>> +
>>> + if (vpfe_cfg) {
>>> + vpfe_capture_dev.dev.platform_data = vpfe_cfg;
>>> + /* Add isif clock alias */
>>
>> This comment is useless. Instead please document why the aliases are
>> needed. I know you are just moving code here, but lets do a clean-up job
>> while at it.
>>
> by document you mean to add a file in Documentation folder ?
No, just modify the comment to talk about why the aliases are needed.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: LAK <linux-arm-kernel@lists.infradead.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] ARM: davinci: dm365: add support for v4l2 video display
Date: Mon, 18 Mar 2013 15:17:54 +0530 [thread overview]
Message-ID: <5146E2CA.8000109@ti.com> (raw)
In-Reply-To: <CA+V-a8umwxKFHjSQ=yDwfp8VWTQyn0dyp-=ESSUvRPXawt01Jg@mail.gmail.com>
On 3/18/2013 2:46 PM, Prabhakar Lad wrote:
> On Mon, Mar 18, 2013 at 1:48 PM, Sekhar Nori <nsekhar@ti.com> wrote:
>> On 3/15/2013 8:41 PM, Prabhakar lad wrote:
>>> +int __init dm365_init_video(struct vpfe_config *vpfe_cfg,
>>> + struct vpbe_config *vpbe_cfg)
>>> +{
>>> + if (vpfe_cfg || vpbe_cfg)
>>> + platform_device_register(&dm365_vpss_device);
>>> +
>>> + if (vpfe_cfg) {
>>> + vpfe_capture_dev.dev.platform_data = vpfe_cfg;
>>> + /* Add isif clock alias */
>>
>> This comment is useless. Instead please document why the aliases are
>> needed. I know you are just moving code here, but lets do a clean-up job
>> while at it.
>>
> by document you mean to add a file in Documentation folder ?
No, just modify the comment to talk about why the aliases are needed.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-03-18 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 15:11 [PATCH v6 0/2] ARM: davinci: add support for dm365 vpbe display Prabhakar lad
2013-03-15 15:11 ` Prabhakar lad
2013-03-15 15:11 ` [PATCH v6 1/2] ARM: davinci: dm365: add support for v4l2 video display Prabhakar lad
2013-03-15 15:11 ` Prabhakar lad
2013-03-18 8:18 ` Sekhar Nori
2013-03-18 8:18 ` Sekhar Nori
2013-03-18 9:16 ` Prabhakar Lad
2013-03-18 9:16 ` Prabhakar Lad
2013-03-18 9:47 ` Sekhar Nori [this message]
2013-03-18 9:47 ` Sekhar Nori
2013-03-15 15:11 ` [PATCH v6 2/2] ARM: davinci: dm365 EVM: add support for VPBE display Prabhakar lad
2013-03-15 15:11 ` Prabhakar lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5146E2CA.8000109@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.