From: Paolo Bonzini <pbonzini@redhat.com>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gleb Natapov <gleb@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Hu Tao <hutao@cn.fujitsu.com>, qemu-devel <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
Orit Wasserman <owasserm@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Alexander Graf <agraf@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Andrew Jones <drjones@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Sasha Levin <levinsasha928@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] pvevent: pvevent device driver
Date: Mon, 18 Mar 2013 10:55:07 +0100 [thread overview]
Message-ID: <5146E47B.1090902@redhat.com> (raw)
In-Reply-To: <1363376111.2553.6.camel@x230.sbx07502.somerma.wayport.net>
Il 15/03/2013 20:35, Matthew Garrett ha scritto:
> On Thu, 2013-03-14 at 16:51 +0800, Hu Tao wrote:
>
>> + { "MSFT0001", 0},
>
> This seems wrong, and it looks like qemu agrees. Can you resubmit when
> there's agreement on the name?
>
>> + acpi_evaluate_object(handle, "WRPT", &arg_list, NULL);
>
> Is there a spec for this?
Not yet. Hu, in the next version of your QEMU patches you probably will
not need anymore usage information in docs/pvevent.txt. Instead, please
add a spec for both the ISA and ACPI interfaces in docs/spec/pvevent.txt.
> Is the only reason for this to allow guests to notify the host that
> they've panicked? It seems like making use of pstore to push the crash
> dump to the host. as well would be a useful thing to do.
Since we try to limit the amount of VM-specific interfaces we have
(yeah, I know this is one), that would mean implementing APEI in QEMU, I
guess. It is definitely a useful thing to have, but a bit wider in
scope than a simple device to distinguish idle and crashed VMs.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gleb Natapov <gleb@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Hu Tao <hutao@cn.fujitsu.com>, qemu-devel <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
Orit Wasserman <owasserm@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Alexander Graf <agraf@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Andrew Jones <drjones@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Sasha Levin <levinsasha928@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH] pvevent: pvevent device driver
Date: Mon, 18 Mar 2013 10:55:07 +0100 [thread overview]
Message-ID: <5146E47B.1090902@redhat.com> (raw)
In-Reply-To: <1363376111.2553.6.camel@x230.sbx07502.somerma.wayport.net>
Il 15/03/2013 20:35, Matthew Garrett ha scritto:
> On Thu, 2013-03-14 at 16:51 +0800, Hu Tao wrote:
>
>> + { "MSFT0001", 0},
>
> This seems wrong, and it looks like qemu agrees. Can you resubmit when
> there's agreement on the name?
>
>> + acpi_evaluate_object(handle, "WRPT", &arg_list, NULL);
>
> Is there a spec for this?
Not yet. Hu, in the next version of your QEMU patches you probably will
not need anymore usage information in docs/pvevent.txt. Instead, please
add a spec for both the ISA and ACPI interfaces in docs/spec/pvevent.txt.
> Is the only reason for this to allow guests to notify the host that
> they've panicked? It seems like making use of pstore to push the crash
> dump to the host. as well would be a useful thing to do.
Since we try to limit the amount of VM-specific interfaces we have
(yeah, I know this is one), that would mean implementing APEI in QEMU, I
guess. It is definitely a useful thing to have, but a bit wider in
scope than a simple device to distinguish idle and crashed VMs.
Paolo
next prev parent reply other threads:[~2013-03-18 9:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 8:51 [Qemu-devel] [PATCH] pvevent: pvevent device driver Hu Tao
2013-03-14 9:07 ` Gleb Natapov
2013-03-14 9:07 ` [Qemu-devel] " Gleb Natapov
2013-03-15 19:35 ` Matthew Garrett
2013-03-15 19:35 ` [Qemu-devel] " Matthew Garrett
2013-03-18 9:55 ` Paolo Bonzini [this message]
2013-03-18 9:55 ` Paolo Bonzini
2013-03-19 5:49 ` Hu Tao
2013-03-19 5:49 ` [Qemu-devel] " Hu Tao
2013-03-17 19:12 ` Blue Swirl
2013-03-17 19:12 ` [Qemu-devel] " Blue Swirl
2013-03-19 5:45 ` Hu Tao
2013-03-19 5:45 ` [Qemu-devel] " Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5146E47B.1090902@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=drjones@redhat.com \
--cc=gleb@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=jan.kiszka@siemens.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=matthew.garrett@nebula.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=owasserm@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.