From: Gary Thomas <samoht.yrag@gmail.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm][PATCH] xf86-dri-vivante: Fix build with latest X server base
Date: Tue, 19 Mar 2013 07:41:22 -0600 [thread overview]
Message-ID: <51486B02.6000006@gmail.com> (raw)
In-Reply-To: <CAP9ODKqFk53S9xPYV-t3oJ2c1uF2Sc=W8w0-s=mzZebgt1vZTQ@mail.gmail.com>
On 2013-03-19 07:33, Otavio Salvador wrote:
> On Tue, Mar 19, 2013 at 10:19 AM, Gary Thomas <samoht.yrag@gmail.com> wrote:
>> mibstore functions are no longer supported. This patch
>> removes them from this driver.
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>> ---
>> .../xf86-dri-vivante/remove-mibstore.patch | 24
>> ++++++++++++++++++++
>> .../xorg-driver/xf86-dri-vivante_12.09.01.bb | 4 +++-
>> 2 files changed, 27 insertions(+), 1 deletion(-)
>> create mode 100644
>> recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch
>>
>> diff --git
>> a/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch
>> b/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch
>> new file mode 100644
>> index 0000000..1c48563
>> --- /dev/null
>> +++ b/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch
>> @@ -0,0 +1,24 @@
>> +Index:
>> xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h
>> +===================================================================
>> +---
>> xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_util/vivante_common.h
>> ++++ xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h
>> +@@ -48,7 +48,6 @@ extern "C" {
>> + + + #include "mipointer.h"
>> +-#include "mibstore.h"
>> + #include "micmap.h"
>> + #include "mipointrst.h"
>> + #include "inputstr.h"
>> +Index:
>> xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c
>> +===================================================================
>> +---
>> xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_fbdev/vivante_fbdev_driver.c
>> ++++
>> xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c
>> +@@ -746,7 +746,6 @@ VivScreenInit(SCREEN_INIT_ARGS_DECL) {
>> + + + xf86SetBlackWhitePixels(pScreen);
>> +- miInitializeBackingStore(pScreen);
>> + xf86SetBackingStore(pScreen);
>> + + pScrn->vtSema = TRUE;
>
> What the side effects of this change?
Unknown, but it seems to work fine. I found this same change in other
drivers in OE, e.g.
http://patches.openembedded.org/patch/46133/
This checkin shows when/where that file was deleted and mentions the reasons.
http://lists.x.org/archives/xorg-devel/2012-September/033575.html
>
>> diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb
>> b/recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb
>> index acc5479..9f63fb8 100644
>> --- a/recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb
>> +++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb
>> @@ -6,7 +6,9 @@ SECTION = "x11/base"
>> DEPENDS = "virtual/libx11 util-macros xf86-video-imxfb-vivante"
>> LIC_FILES_CHKSUM =
>> "file://src/dri.h;enline=27;md5=79a9064e49ae41adca4827cd2281a014"
>> -SRC_URI = "${FSL_MIRROR}/dri-xorg-graphic-imx-viv-${PV}.bin;fsl-eula=true"
>> +SRC_URI = "${FSL_MIRROR}/dri-xorg-graphic-imx-viv-${PV}.bin;fsl-eula=true \
>> + file://remove-mibstore.patch \
>> +"
>> SRC_URI[md5sum] = "8c90045cd5f4dba81095856634ba5136"
>> SRC_URI[sha256sum] =
>> "c844dc180e43901359bbdb4f797ab178b3821fbf63bdee9577e5a0afe5d7f6ad"
>> -- 1.7.9.5
next prev parent reply other threads:[~2013-03-19 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 13:19 [meta-fsl-arm][PATCH] xf86-dri-vivante: Fix build with latest X server base Gary Thomas
2013-03-19 13:33 ` Otavio Salvador
2013-03-19 13:41 ` Gary Thomas [this message]
2013-03-19 13:45 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51486B02.6000006@gmail.com \
--to=samoht.yrag@gmail.com \
--cc=meta-freescale@yoctoproject.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.