Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

[Peter Lieven <pl@kamp.de>]

On 19.03.2013 12:18, Paolo Bonzini wrote:
> Il 19/03/2013 09:51, Markus Armbruster ha scritto:
>> Paolo, please have a look.
> Why isn't it enough to call bdrv_init_with_whitelist earlier?
>
> There is no conditional logic in it, the whitelist is checked at open time.

Has anyone tested if -spice is working? In this case bdrv_init_with_whitelist() won't help here.

Anyway, I would like to change the -iscsi code in vl.c to throw an error, if iscsi support is not
compiled in (like it is done with spice).

Peter

>
> Paolo
>
>> Peter Lieven <pl@kamp.de> writes:
>>
>>> current git master segfaults if an iscsi option is specified
>>> in command line.
>>>
>>> Peter Lieven (2):
>>>    qemu-option: avoid segfault if QemuOptsList == NULL
>>>    vl.c: fix segfault in iscsi options parsing
>>>
>>>   block/iscsi.c      |   27 ---------------------------
>>>   util/qemu-option.c |    1 +
>>>   vl.c               |   40 +++++++++++++++++++++++++++++++++++++---
>>>   3 files changed, 38 insertions(+), 30 deletions(-)
>>


-- 

Mit freundlichen Grüßen

Peter Lieven

...........................................................

   KAMP Netzwerkdienste GmbH
   Vestische Str. 89-91 | 46117 Oberhausen
   Tel: +49 (0) 208.89 402-50 | Fax: +49 (0) 208.89 402-40
   pl@kamp.de | http://www.kamp.de

   Geschäftsführer: Heiner Lante | Michael Lante
   Amtsgericht Duisburg | HRB Nr. 12154
   USt-Id-Nr.: DE 120607556

...........................................................