From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V2 1/3] ARM: dts: tegra: add clock source for PMC
Date: Tue, 19 Mar 2013 10:42:46 -0600 [thread overview]
Message-ID: <51489586.9090605@wwwdotorg.org> (raw)
In-Reply-To: <1363594199-10974-2-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 03/18/2013 02:09 AM, Joseph Lo wrote:
> The clock source of PMC is PCLK. Adding it into DTS for Tegra20 and Tegra30.
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> pmc {
> compatible = "nvidia,tegra20-pmc";
> reg = <0x7000e400 0x400>;
> + clocks = <&tegra_car 110>;
> };
The DT binding documentation needs to list the set of clocks that must
be present.
Doesn't the PMC also receive a "clk32k_in" from the PMIC, or is that
routed into the CAR, and then into the PMC? Either way, the PMC module
receives that clock somehow. Since there are multiple clocks, that also
means that a clock-names property is required.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/3] ARM: dts: tegra: add clock source for PMC
Date: Tue, 19 Mar 2013 10:42:46 -0600 [thread overview]
Message-ID: <51489586.9090605@wwwdotorg.org> (raw)
In-Reply-To: <1363594199-10974-2-git-send-email-josephl@nvidia.com>
On 03/18/2013 02:09 AM, Joseph Lo wrote:
> The clock source of PMC is PCLK. Adding it into DTS for Tegra20 and Tegra30.
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> pmc {
> compatible = "nvidia,tegra20-pmc";
> reg = <0x7000e400 0x400>;
> + clocks = <&tegra_car 110>;
> };
The DT binding documentation needs to list the set of clocks that must
be present.
Doesn't the PMC also receive a "clk32k_in" from the PMIC, or is that
routed into the CAR, and then into the PMC? Either way, the PMC module
receives that clock somehow. Since there are multiple clocks, that also
means that a clock-names property is required.
next prev parent reply other threads:[~2013-03-19 16:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 8:09 [PATCH V2 0/3] ARM: tegra: add clock source for PMC Joseph Lo
2013-03-18 8:09 ` Joseph Lo
[not found] ` <1363594199-10974-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-18 8:09 ` [PATCH V2 1/3] ARM: dts: " Joseph Lo
2013-03-18 8:09 ` Joseph Lo
[not found] ` <1363594199-10974-2-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-19 16:42 ` Stephen Warren [this message]
2013-03-19 16:42 ` Stephen Warren
[not found] ` <51489586.9090605-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-20 10:12 ` Joseph Lo
2013-03-20 10:12 ` Joseph Lo
[not found] ` <1363774325.5697.19.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org>
2013-03-20 15:54 ` Stephen Warren
2013-03-20 15:54 ` Stephen Warren
2013-03-18 8:09 ` [PATCH V2 2/3] ARM: tegra: get PMC clock source from DT Joseph Lo
2013-03-18 8:09 ` Joseph Lo
[not found] ` <1363594199-10974-3-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-19 16:40 ` Stephen Warren
2013-03-19 16:40 ` Stephen Warren
[not found] ` <51489513.1020107-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-20 10:00 ` Joseph Lo
2013-03-20 10:00 ` Joseph Lo
[not found] ` <1363773608.5697.8.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org>
2013-03-20 15:51 ` Stephen Warren
2013-03-20 15:51 ` Stephen Warren
2013-03-18 8:09 ` [PATCH V2 3/3] ARM: tegra: moving the CPU power timer function to PMC driver Joseph Lo
2013-03-18 8:09 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51489586.9090605@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.