From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V4 2/9] ARM: tegra: irq: add wake up handling
Date: Tue, 19 Mar 2013 10:55:38 -0600 [thread overview]
Message-ID: <5148988A.4020409@wwwdotorg.org> (raw)
In-Reply-To: <1363594400-11663-3-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 03/18/2013 02:13 AM, Joseph Lo wrote:
> Add the wake up handling for legacy irq controller, and using
> IRQCHIP_MASK_ON_SUSPEND for wake irq handling.
> diff --git a/arch/arm/mach-tegra/irq.c b/arch/arm/mach-tegra/irq.c
> +static int tegra_set_wake(struct irq_data *d, unsigned int enable)
> +{
> + u32 irq = d->irq;
> + u32 index, mask;
> +
> + BUG_ON(irq < FIRST_LEGACY_IRQ ||
> + irq >= FIRST_LEGACY_IRQ + num_ictlrs * 32);
Perhaps that should be:
if (irq < FIRST_LEGACY_IRQ ||
irq >= FIRST_LEGACY_IRQ + num_ictlrs * 32)
return -EINVAL;
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 2/9] ARM: tegra: irq: add wake up handling
Date: Tue, 19 Mar 2013 10:55:38 -0600 [thread overview]
Message-ID: <5148988A.4020409@wwwdotorg.org> (raw)
In-Reply-To: <1363594400-11663-3-git-send-email-josephl@nvidia.com>
On 03/18/2013 02:13 AM, Joseph Lo wrote:
> Add the wake up handling for legacy irq controller, and using
> IRQCHIP_MASK_ON_SUSPEND for wake irq handling.
> diff --git a/arch/arm/mach-tegra/irq.c b/arch/arm/mach-tegra/irq.c
> +static int tegra_set_wake(struct irq_data *d, unsigned int enable)
> +{
> + u32 irq = d->irq;
> + u32 index, mask;
> +
> + BUG_ON(irq < FIRST_LEGACY_IRQ ||
> + irq >= FIRST_LEGACY_IRQ + num_ictlrs * 32);
Perhaps that should be:
if (irq < FIRST_LEGACY_IRQ ||
irq >= FIRST_LEGACY_IRQ + num_ictlrs * 32)
return -EINVAL;
next prev parent reply other threads:[~2013-03-19 16:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 8:13 [PATCH V4 0/9] ARM: tegra: add platform suspend support Joseph Lo
2013-03-18 8:13 ` Joseph Lo
[not found] ` <1363594400-11663-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-18 8:13 ` [PATCH V4 1/9] gpio: tegra: add gpio wakeup source handling Joseph Lo
2013-03-18 8:13 ` Joseph Lo
[not found] ` <1363594400-11663-2-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-19 16:52 ` Stephen Warren
2013-03-19 16:52 ` Stephen Warren
2013-03-18 8:13 ` [PATCH V4 2/9] ARM: tegra: irq: add wake up handling Joseph Lo
2013-03-18 8:13 ` Joseph Lo
[not found] ` <1363594400-11663-3-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-19 16:55 ` Stephen Warren [this message]
2013-03-19 16:55 ` Stephen Warren
2013-03-18 8:13 ` [PATCH V4 3/9] ARM: dt: tegra: add bindings of power management configurations for PMC Joseph Lo
2013-03-18 8:13 ` Joseph Lo
[not found] ` <1363594400-11663-4-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-19 17:00 ` Stephen Warren
2013-03-19 17:00 ` Stephen Warren
[not found] ` <5148999A.90102-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-19 17:26 ` Stephen Warren
2013-03-19 17:26 ` Stephen Warren
2013-03-18 8:13 ` [PATCH V4 4/9] ARM: tegra: pm: add platform suspend support Joseph Lo
2013-03-18 8:13 ` Joseph Lo
[not found] ` <1363594400-11663-5-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-19 17:07 ` Stephen Warren
2013-03-19 17:07 ` Stephen Warren
[not found] ` <51489B5D.3050101-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-20 10:26 ` Joseph Lo
2013-03-20 10:26 ` Joseph Lo
2013-03-18 8:13 ` [PATCH V4 5/9] ARM: dts: tegra: add power gpio keys to DT Joseph Lo
2013-03-18 8:13 ` Joseph Lo
2013-03-18 8:13 ` [PATCH V4 6/9] ARM: dts: tegra: whistler: add wakeup source for KBC Joseph Lo
2013-03-18 8:13 ` Joseph Lo
2013-03-18 8:13 ` [PATCH V4 7/9] ARM: dts: tegra: add non-removable and keep-power-in-suspend property for MMC Joseph Lo
2013-03-18 8:13 ` Joseph Lo
2013-03-18 8:13 ` [PATCH V4 8/9] ARM: tegra: config: defconfig update Joseph Lo
2013-03-18 8:13 ` Joseph Lo
2013-03-18 8:13 ` [PATCH V4 9/9] ARM: dts: tegra: add the PM configurations of PMC Joseph Lo
2013-03-18 8:13 ` Joseph Lo
2013-03-19 16:51 ` [PATCH V4 0/9] ARM: tegra: add platform suspend support Stephen Warren
2013-03-19 16:51 ` Stephen Warren
[not found] ` <5148977F.7000700-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-20 10:15 ` Joseph Lo
2013-03-20 10:15 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5148988A.4020409@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.