All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Cc: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	romain.naour-oid7hba3+9NWj0EZb7rXcA@public.gmane.org,
	kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	drwyrm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	stefan-WB6LKoYH/xlAfugRpC6u6w@public.gmane.org,
	laforge-WB6LKoYH/xlAfugRpC6u6w@public.gmane.org,
	philipp.zabel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	lost.distance-/E1597aS9LQAvxtiuMwx3w@public.gmane.org,
	robert.jarzmik-GANU6spQydw@public.gmane.org,
	eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org,
	shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org,
	thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org,
	acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	openezx-devel-ZwoEplunGu3n3BO9LpVK+9i2O/JbrIOy@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Subject: Re: [PATCH V4 6/9] ARM: mxs: Provide regulator to pwm-backlight
Date: Tue, 19 Mar 2013 16:10:26 -0600	[thread overview]
Message-ID: <5148E252.9050900@wwwdotorg.org> (raw)
In-Reply-To: <201303192227.21717.marex-ynQEQJNshbs@public.gmane.org>

On 03/19/2013 03:27 PM, Marek Vasut wrote:
> Dear Andrew Chew,
> 
>> The pwm-backlight driver now takes a mandatory regulator that is gotten
>> during driver probe.  Initialize a dummy regulator to satisfy this
>> requirement.
>>
>> Signed-off-by: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> Do we really need a mandatory regulator? Why can't it be optional?

IIRC, the previous advice I've seen is that if a device (driver) uses a
regulator, it must /require/ a regulator, and if a particular board
doesn't actually have a SW-controlled regulator, then a fixed- or dummy-
regulator should be provided to satisfy this requirement.

CC'ing Mark Brown to make sure I really do Recall Correctly.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 6/9] ARM: mxs: Provide regulator to pwm-backlight
Date: Tue, 19 Mar 2013 16:10:26 -0600	[thread overview]
Message-ID: <5148E252.9050900@wwwdotorg.org> (raw)
In-Reply-To: <201303192227.21717.marex@denx.de>

On 03/19/2013 03:27 PM, Marek Vasut wrote:
> Dear Andrew Chew,
> 
>> The pwm-backlight driver now takes a mandatory regulator that is gotten
>> during driver probe.  Initialize a dummy regulator to satisfy this
>> requirement.
>>
>> Signed-off-by: Andrew Chew <achew@nvidia.com>
> 
> Do we really need a mandatory regulator? Why can't it be optional?

IIRC, the previous advice I've seen is that if a device (driver) uses a
regulator, it must /require/ a regulator, and if a particular board
doesn't actually have a SW-controlled regulator, then a fixed- or dummy-
regulator should be provided to satisfy this requirement.

CC'ing Mark Brown to make sure I really do Recall Correctly.

  parent reply	other threads:[~2013-03-19 22:10 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 18:59 [PATCH V4 0/9] Add mandatory regulator for all users of pwm-backlight Andrew Chew
2013-03-19 18:59 ` Andrew Chew
2013-03-19 18:59 ` [PATCH V4 3/9] ARM: pxa: Provide regulator to pwm-backlight Andrew Chew
2013-03-19 18:59   ` Andrew Chew
     [not found] ` <1363719573-20926-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-19 18:59   ` [PATCH V4 1/9] ARM: OMAP: board-4430sdp: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-19 18:59   ` [PATCH V4 2/9] ARM: S3C24XX: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-19 18:59   ` [PATCH V4 4/9] ARM: EXYNOS: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-19 18:59   ` [PATCH V4 5/9] unicore32: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-19 18:59   ` [PATCH V4 6/9] ARM: mxs: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-19 21:27     ` Marek Vasut
2013-03-19 21:27       ` Marek Vasut
2013-03-19 21:31       ` Andrew Chew
2013-03-19 21:31         ` Andrew Chew
2013-03-19 21:35         ` Marek Vasut
2013-03-19 21:35           ` Marek Vasut
     [not found]       ` <201303192227.21717.marex-ynQEQJNshbs@public.gmane.org>
2013-03-19 22:10         ` Stephen Warren [this message]
2013-03-19 22:10           ` Stephen Warren
2013-03-20  8:23           ` Mark Brown
2013-03-20  8:23             ` Mark Brown
     [not found]             ` <20130320082318.GA28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 14:03               ` Marek Vasut
2013-03-20 14:03                 ` Marek Vasut
2013-03-20  3:13     ` Shawn Guo
2013-03-20  3:13       ` Shawn Guo
2013-03-19 18:59   ` [PATCH V4 7/9] ARM: vt8500: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-20 18:18     ` [Bulk] " Tony Prisk
2013-03-20 18:18       ` Tony Prisk
2013-03-19 18:59   ` [PATCH V4 8/9] ARM: tegra: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-21 20:01     ` Stephen Warren
2013-03-21 20:01       ` Stephen Warren
     [not found]     ` <1363719573-20926-9-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-22 10:29       ` Thierry Reding
2013-03-22 10:29         ` Thierry Reding
2013-03-19 18:59   ` [PATCH V4 9/9] pwm_bl: Add mandatory backlight enable regulator Andrew Chew
2013-03-19 18:59     ` Andrew Chew
     [not found]     ` <1363719573-20926-10-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 18:00       ` Stephen Warren
2013-03-20 18:00         ` Stephen Warren
     [not found]         ` <5149F92A.3070004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-20 22:19           ` Thierry Reding
2013-03-20 22:19             ` Thierry Reding
2013-03-20  2:14 ` [PATCH V4 0/9] Add mandatory regulator for all users of pwm-backlight Shawn Guo
2013-03-20  2:14   ` Shawn Guo
2013-03-20  2:24   ` Alex Courbot
2013-03-20  2:24     ` Alex Courbot
2013-03-20  3:08     ` Shawn Guo
2013-03-20  3:08       ` Shawn Guo
2013-03-20  7:13     ` Tony Prisk
2013-03-20  7:13       ` Tony Prisk
2013-03-22  1:57 ` Alex Courbot
2013-03-22  1:57   ` Alex Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5148E252.9050900@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=drwyrm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org \
    --cc=haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=laforge-WB6LKoYH/xlAfugRpC6u6w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lost.distance-/E1597aS9LQAvxtiuMwx3w@public.gmane.org \
    --cc=marex-ynQEQJNshbs@public.gmane.org \
    --cc=openezx-devel-ZwoEplunGu3n3BO9LpVK+9i2O/JbrIOy@public.gmane.org \
    --cc=philipp.zabel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robert.jarzmik-GANU6spQydw@public.gmane.org \
    --cc=romain.naour-oid7hba3+9NWj0EZb7rXcA@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=stefan-WB6LKoYH/xlAfugRpC6u6w@public.gmane.org \
    --cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.