From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com, linux-ext4@vger.kernel.org,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH v2] xfstests: add a new test case for ext4 indirect-based file
Date: Wed, 20 Mar 2013 00:37:42 -0500 [thread overview]
Message-ID: <51494B26.6020204@sandeen.net> (raw)
In-Reply-To: <20130320054555.GB4017@gmail.com>
On 3/20/13 12:45 AM, Zheng Liu wrote:
>>> +f6aeca13ec49e5b266cd1c913cd726e3
>>> > > + 12. unwritten -> data -> unwritten
>> >
>> > It's a little odd that the output contains "unwritten" when this test
>> > is explicitly for testing *without* unwritten extents. Should this be
>> > cleaned up a little in common.punch, maybe?
> I will try to define a new function called _test_indirect_punch() to
> test punching hole without unwritten extent.
It's just the helper which prints "unwritten" regardless of what
is passed as "$alloc_cmd" to _test_generic_punch, right... so there's
nothing wrong with the test, really - it's just odd output.
I'm not sure it's worth a big copy & paste just to change
the output text, but if you can think of something simple to clean
it up, it might be worth it.
-Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com, linux-ext4@vger.kernel.org,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH v2] xfstests: add a new test case for ext4 indirect-based file
Date: Wed, 20 Mar 2013 00:37:42 -0500 [thread overview]
Message-ID: <51494B26.6020204@sandeen.net> (raw)
In-Reply-To: <20130320054555.GB4017@gmail.com>
On 3/20/13 12:45 AM, Zheng Liu wrote:
>>> +f6aeca13ec49e5b266cd1c913cd726e3
>>> > > + 12. unwritten -> data -> unwritten
>> >
>> > It's a little odd that the output contains "unwritten" when this test
>> > is explicitly for testing *without* unwritten extents. Should this be
>> > cleaned up a little in common.punch, maybe?
> I will try to define a new function called _test_indirect_punch() to
> test punching hole without unwritten extent.
It's just the helper which prints "unwritten" regardless of what
is passed as "$alloc_cmd" to _test_generic_punch, right... so there's
nothing wrong with the test, really - it's just odd output.
I'm not sure it's worth a big copy & paste just to change
the output text, but if you can think of something simple to clean
it up, it might be worth it.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-20 5:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 8:53 [PATCH v2] xfstests: add a new test case for ext4 indirect-based file Zheng Liu
2013-03-19 8:53 ` Zheng Liu
2013-03-19 16:29 ` Eric Sandeen
2013-03-19 16:29 ` Eric Sandeen
2013-03-20 5:45 ` Zheng Liu
2013-03-20 5:45 ` Zheng Liu
2013-03-20 5:37 ` Eric Sandeen [this message]
2013-03-20 5:37 ` Eric Sandeen
2013-03-21 1:06 ` Dave Chinner
2013-03-21 1:06 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51494B26.6020204@sandeen.net \
--to=sandeen@sandeen.net \
--cc=linux-ext4@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.