All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"lrg-l0cyMroinI0@public.gmane.org"
	<lrg-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 2/2] regulator: palmas: add input supply names
Date: Wed, 20 Mar 2013 19:02:30 +0530	[thread overview]
Message-ID: <5149BA6E.7070003@nvidia.com> (raw)
In-Reply-To: <20130320132531.GO28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>

On Wednesday 20 March 2013 06:55 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Mar 20, 2013 at 06:24:54PM +0530, Laxman Dewangan wrote:
>
>> The regulator core register the regulator even if there is NULL
>> init_data and in this case, it tries to findout the input-supply
>> (provided through desc->supply_name) and it fails to find out the
>> supply handle and so regulator register fails cause all regulator
>> registration to fail.
>> So providing the dec->supply_name only in case of valid init_data.
> This works fine if you have a device per regulator instead of a device
> for all the regulators on the chip...  I would be inclined to address
> this by providing a "floating" supply and connecting everythinng to
> that.
I am fine with adding floating supply similar to below and connect all 
non-connected supply pins to this.

                 floating: regulator@1 {
                         compatible = "regulator-fixed";
                         reg = <1>;
                         regulator-name = "floating";
                 };

If this is fine then I will respin the patch to remove condition.

WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stephen Warren <swarren@nvidia.com>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"lrg@ti.com" <lrg@ti.com>
Subject: Re: [PATCH 2/2] regulator: palmas: add input supply names
Date: Wed, 20 Mar 2013 19:02:30 +0530	[thread overview]
Message-ID: <5149BA6E.7070003@nvidia.com> (raw)
In-Reply-To: <20130320132531.GO28775@opensource.wolfsonmicro.com>

On Wednesday 20 March 2013 06:55 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Mar 20, 2013 at 06:24:54PM +0530, Laxman Dewangan wrote:
>
>> The regulator core register the regulator even if there is NULL
>> init_data and in this case, it tries to findout the input-supply
>> (provided through desc->supply_name) and it fails to find out the
>> supply handle and so regulator register fails cause all regulator
>> registration to fail.
>> So providing the dec->supply_name only in case of valid init_data.
> This works fine if you have a device per regulator instead of a device
> for all the regulators on the chip...  I would be inclined to address
> this by providing a "floating" supply and connecting everythinng to
> that.
I am fine with adding floating supply similar to below and connect all 
non-connected supply pins to this.

                 floating: regulator@1 {
                         compatible = "regulator-fixed";
                         reg = <1>;
                         regulator-name = "floating";
                 };

If this is fine then I will respin the patch to remove condition.


  parent reply	other threads:[~2013-03-20 13:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-18  9:29 [PATCH 2/2] regulator: palmas: add input supply names Laxman Dewangan
2013-03-18  9:29 ` Laxman Dewangan
2013-03-18  9:29 ` [PATCH 1/2] regulator: palmas: rename probe/remove callback functions Laxman Dewangan
2013-03-18  9:29   ` Laxman Dewangan
     [not found] ` <20130320123128.GM28775@opensource.wolfsonmicro.com>
     [not found]   ` <20130320123128.GM28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 12:54     ` [PATCH 2/2] regulator: palmas: add input supply names Laxman Dewangan
2013-03-20 12:54       ` Laxman Dewangan
     [not found]       ` <20130320132531.GO28775@opensource.wolfsonmicro.com>
     [not found]         ` <20130320132531.GO28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 13:32           ` Laxman Dewangan [this message]
2013-03-20 13:32             ` Laxman Dewangan
     [not found]       ` <5149B19E.90400-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 16:07         ` Stephen Warren
2013-03-20 16:07           ` Stephen Warren
     [not found]           ` <20130320163833.GT28775@opensource.wolfsonmicro.com>
     [not found]             ` <20130320163833.GT28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 16:42               ` Stephen Warren
2013-03-20 16:42                 ` Stephen Warren
     [not found]                 ` <20130320165227.GU28775@opensource.wolfsonmicro.com>
     [not found]                   ` <20130320165227.GU28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 16:56                     ` Stephen Warren
2013-03-20 16:56                       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5149BA6E.7070003@nvidia.com \
    --to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lrg-l0cyMroinI0@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.