From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Jan Kara <jack@suse.cz>, xfs@oss.sgi.com
Subject: Re: [PATCH v2] Count journal size in test 289
Date: Wed, 20 Mar 2013 09:37:45 -0500 [thread overview]
Message-ID: <5149C9B9.2060900@sgi.com> (raw)
In-Reply-To: <5149C824.8070300@sandeen.net>
On 03/20/2013 09:31 AM, Eric Sandeen wrote:
> On 3/20/13 5:50 AM, Jan Kara wrote:
>> Test 289 ignored the fact that historically journal is not accounted as
>> fs overhead in ext3. For larger filesystems it is hidden in 1% tolerance
>> but for filesystems smaller than 12G the test fails. So make the
>> counting precise to work everywhere.
>>
>> CC: Eric Sandeen <sandeen@sandeen.net>
>> Signed-off-by: Jan Kara <jack@suse.cz>
>
> Looks fine, thanks.
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
>
> p.s. - sorry, didn't catch this the first time:
>
> _filter_size_to_bytes won't work for lowercase units, which might
> be nice. How about:
>
>> + case $suffix in
>> + k|K) mul=1024 ;;
>> + m|M) mul=$((1024*1024)) ;;
>> + g|G) mul=$((1024*1024*1024)) ;;
>> + t|T) mul=$((1024*1024*1024*1024)) ;;
>> + esac
>
> SGI guys - maybe could do that as a small fix-up on commit. Otherwise, if anyone
> ever needs lower case they could just add it at the same time, so no big deal.
Will do thanks for the review.
--Rich
>
> -Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-20 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 10:50 [PATCH v2] Count journal size in test 289 Jan Kara
2013-03-20 14:31 ` Eric Sandeen
2013-03-20 14:37 ` Rich Johnston [this message]
2013-03-20 16:00 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5149C9B9.2060900@sgi.com \
--to=rjohnston@sgi.com \
--cc=jack@suse.cz \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.